Skip to content

include more than one file will cause error #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
Erimus-Koo opened this issue Mar 19, 2020 · 5 comments
Closed
1 task

include more than one file will cause error #1084

Erimus-Koo opened this issue Mar 19, 2020 · 5 comments
Labels

Comments

@Erimus-Koo
Copy link

Bug Report

Steps to reproduce

  • In one markdown file, use more than one "include", like:
# something before

[file1](test.assets/file1.html  ':include :type=iframe width=100% height=500px')
[file2](test.assets/file2.html  ':include :type=iframe width=100% height=500px')

# something after

What is current behaviour

  • While include only one file, display is all good.
  • But if include two, the whole page will only display the 2nd iframe. Other parts of markdown will disappear.
  • Actually, if include more than one, it always show the last iframe only.

What is the expected behaviour

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: 4.11.2

  • Docsify plugins:

@anikethsaha
Copy link
Member

can you try without the height property !?

@Erimus-Koo
Copy link
Author

iframe1 height iframe2 height iframe1 display iframe2 display other elements
500px 500px none 500px none
500px none none ~100px none
none 500px none 500px none
none none none ~100px none

There's only one time, I keep the "height" of 1st one and remove the 2nd, both iframe display and the 2nd looks 100px height. But I can not replay it, maybe cause by cache or some details different in code, I'm not sure.

@anikethsaha
Copy link
Member

this needs investigation

feel free to investigate and submit the fix.

It will take time for me as I am quite busy with some other stuff.

@randName
Copy link

  • Actually, if include more than one, it always show the last iframe only.

sounds similar to what I faced in #1078 so it's probably the same issue
unfortunately it is not critical for my stuff now so I have not taken a look yet

@stale
Copy link

stale bot commented May 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 25, 2020
@stale stale bot closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants