Skip to content

Markdown include not stripping YAML front matter #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
sytone opened this issue Apr 21, 2020 · 1 comment · Fixed by #1148
Closed
1 task done

Markdown include not stripping YAML front matter #1129

sytone opened this issue Apr 21, 2020 · 1 comment · Fixed by #1148
Labels
bug confirmed as a bug pr welcome

Comments

@sytone
Copy link
Contributor

sytone commented Apr 21, 2020

Bug Report

Steps to reproduce

  1. Create a Markdown Page to view
  2. Create a markdown page to include with a YAML header.
  3. Add a link with the include tag to the page.
  4. View the markdown page with the link and when the link I parsed the YAML header is also pulled through and rendered as markdown putting a line on the page followed by the YAML header information as test and then another line.

What is current behaviour

When the link I parsed the YAML header is also pulled through and rendered as markdown putting a line on the page followed by the YAML header information as test and then another line.

What is the expected behaviour

The markdown is rendered from the include should only have the markdown rendered and not the YAML front matter.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Windows

  • Node.js version: NA

  • npm/yarn version: NA

  • Browser version: Edge and Chrome latest

  • Docsify version: Latest (4.11.3)

  • Docsify plugins: None

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@anikethsaha anikethsaha added bug confirmed as a bug pr welcome labels Apr 22, 2020
@anikethsaha
Copy link
Member

Thanks for the issue and filling the template and creating a repro sandbox. it helps a lot 🥇

I can confirm this is a bug and should be fixed.

anikethsaha added a commit that referenced this issue May 7, 2020
Updated embed to strip YAML front matter fixes #1129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants