-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix #970, updated the insertion of embedded tokens for async returns #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #970, updated the insertion of embedded tokens for async returns #1102
Conversation
…dded token results returning in any order fixes #970
When I initially opened this, 2 of the e2e test phases were marked as failed. I was able to investigate this morning. The only errors were timeouts in the before phases of the test suite. I ran the e2e tests locally without issue and have re-pushed the change. This time everything passed without issue. I believe the original failure was simply an intermittent failure of the test framework setup. I have also done some basic testing with Firefox and Safari, in addition to my additional tests in Chrome. I am not planning further updates, at this time. This change seems to effectively fix #970 in my use cases. Please let me know if there is anything else I can do to assist in getting this merged. |
thanks for the PR and sorry for the delayed. |
cc @docsifyjs/reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test all the embed file cases we supported, it works fine. 💯
@Koooooo-7 can you |
This is affecting us, too. Any chance it could be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor suggestion
Summary
fix #970 - updated the insertion of embedded tokens so it correctly handles embedded token results returning in any order
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Yes
No
When resolving a specific issue, it's referenced in the PR's title (e.g.
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
Other information:
The previous implementation incorrectly assumed that contents of embedded content would be returned in the order they were requested in the document. This created unpredictable race conditions when multiple embeds were included.
I have run into this issue with embedded markdown, and have only attempted test-cases surrounding the markdown content specifically.
lib
directory.