Skip to content

Modernized constructors and added return types for PHP compatibility #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modernized constructors and added return types for PHP compatibility #239

wants to merge 1 commit into from

Conversation

moses197
Copy link

What Changed

  • Updated constructors in Api, Client, and Model files (including Configuration.php) with ?array $data = null to fix PHP deprecation warnings.
  • Added return types (bool, mixed, void) to improve type safety and compatibility.

Why It’s Needed

  • Fixes PHP deprecation warnings and ensures compatibility with modern PHP versions.
  • Enhances code clarity and maintainability.

Considerations

  • Fully backward-compatible with PHP versions that support nullable types and return type declarations.
  • Minimum PHP version requirements may need updating.

@WektorPriv
Copy link

Great, I have an issue right now based on those incompatibilities. Do you know maybe when it would be merged?

@moses197
Copy link
Author

Great, I have an issue right now based on those incompatibilities. Do you know maybe when it would be merged?

I don’t really know, but if you need any help, I’m happy to lend a hand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WektorPriv WektorPriv WektorPriv approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moses197 @WektorPriv