feat: allow wasm in nodejs #253
Conversation
WalkthroughThe updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (4)
packages/torii-wasm/build.sh (1)
6-6: Consider adding error handling for git clone.While the
set -exoption will exit on error, it might be useful to provide a more descriptive error message if the clone fails.git clone --depth 1 https://github.com/dojoengine/dojo.c dojo.c || { echo "Failed to clone repository"; exit 1; }packages/torii-wasm/package.json (3)
7-8: Files specified inmainandbrowserentries are missing.The files
./pkg/node/dojo_c.jsand./pkg/web/dojo_c.jsdo not exist in the specified locations. Please verify the build process to ensure these files are generated correctly, or check the paths in thepackage.jsonfor accuracy.
main:./pkg/node/dojo_c.jsis missing.browser:./pkg/web/dojo_c.jsis missing.Analysis chain
Verify the
mainandbrowserentries.Ensure that the paths specified in the
mainandbrowserentries are correct and that the files exist in the specified locations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify existence of main and browser entry files. # Test: Check if the specified files exist. test -f ./pkg/node/dojo_c.js && echo "Node.js main file exists." || echo "Node.js main file is missing." test -f ./pkg/web/dojo_c.js && echo "Browser file exists." || echo "Browser file is missing."Length of output: 188
15-22: Missing Files infilesArrayNone of the files listed in the
filesarray ofpackages/torii-wasm/package.jsonexist in the specified locations. Please verify the build process to ensure these files are correctly generated.
./pkg/web/dojo_c_bg.wasmis missing../pkg/web/dojo_c.jsis missing../pkg/web/dojo_c_bg.jsis missing../pkg/web/dojo_c.d.tsis missing../pkg/node/dojo_c_bg.wasmis missing../pkg/node/dojo_c.jsis missing../pkg/node/dojo_c_bg.jsis missing../pkg/node/dojo_c.d.tsis missing.Analysis chain
Ensure all files in the
filesarray exist.Verify that all the files listed in the
filesarray are correctly generated and exist in the specified locations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify existence of files listed in the files array. # Test: Check if each specified file exists. for file in ./pkg/web/dojo_c_bg.wasm ./pkg/web/dojo_c.js ./pkg/web/dojo_c_bg.js ./pkg/web/dojo_c.d.ts ./pkg/node/dojo_c_bg.wasm ./pkg/node/dojo_c.js ./pkg/node/dojo_c_bg.js ./pkg/node/dojo_c.d.ts; do test -f $file && echo "$file exists." || echo "$file is missing." doneLength of output: 2479
24-25: Missingmoduleandtypesfiles inpackage.json.The files specified in the
moduleandtypesentries (./pkg/web/dojo_c.jsand./pkg/web/dojo_c.d.ts) do not exist. Please verify the build process or correct the paths in thepackage.json.
- Ensure the build process generates these files.
- Check if the paths in
package.jsonare correct.Analysis chain
Verify
moduleandtypesentries.Ensure that the paths specified in the
moduleandtypesentries are correct and that the files exist in the specified locations.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify existence of module and types entry files. # Test: Check if the specified files exist. test -f ./pkg/web/dojo_c.js && echo "Module file exists." || echo "Module file is missing." test -f ./pkg/web/dojo_c.d.ts && echo "Types file exists." || echo "Types file is missing."Length of output: 173
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/torii-wasm/build.sh (1 hunks)
- packages/torii-wasm/package.json (1 hunks)
Additional comments not posted (1)
packages/torii-wasm/build.sh (1)
11-14: Ensure wasm-pack is installed and compatible.Make sure that
wasm-packis installed and the version is compatible with your build requirements. Consider adding a version check or installation instructions.
Allows wasm to run in nodejs env
Summary by CodeRabbit
New Features
Improvements