Skip to content

feat: remove field order from sdk #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: remove field order from sdk #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .changeset/great-olives-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
"@dojoengine/sdk": patch
"template-vite-ts": patch
"@dojoengine/core": patch
"@dojoengine/create-burner": patch
"@dojoengine/create-dojo": patch
"@dojoengine/predeployed-connector": patch
"@dojoengine/react": patch
"@dojoengine/state": patch
"@dojoengine/torii-client": patch
"@dojoengine/torii-wasm": patch
"@dojoengine/utils": patch
"@dojoengine/utils-wasm": patch
Comment on lines +1 to +13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update version bump type to align with semantic versioning.

The changes include a feature removal (field order) which is a feature change, but all packages are marked for patch updates. According to semantic versioning:

  • Patch updates (0.0.x) are for backwards-compatible bug fixes
  • Minor updates (0.x.0) are for new features or feature removals

Consider updating the affected packages (especially @dojoengine/sdk and @dojoengine/torii-client) to use minor version bumps instead of patches.

---

feat: remove field order and bump torii-client
5 changes: 0 additions & 5 deletions packages/sdk/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ export type SchemaType = {
* For example, 'Player', 'Item', 'Quest', etc.
*/
[model: string]: {
/**
* fieldOrder: An array of strings representing the order of fields in the model.
* This is crucial for maintaining consistent field ordering across your application.
*/
fieldOrder: string[];
/**
* Dynamic fields of the model.
* These can be of any type, typically representing the properties of your model.
Expand Down