-
Notifications
You must be signed in to change notification settings - Fork 53
chore: update starknet.js version #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7c05909
90b9e47
9f3cf54
a5a2202
1d54b8b
2241bae
4c85a96
fafd293
e99bc1e
59d3930
5c469f9
6f031c4
cc37801
4a82fff
5d1d5e8
264a02f
dd7e505
318813e
f734538
96855b1
f8b4de0
1aec48a
9c6e40e
7079692
11ac45a
26e3383
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
"@dojoengine/utils": patch | ||
"@dojoengine/sdk": patch | ||
--- | ||
|
||
fix: ensure entity IDs are consistently padded across SDK | ||
|
||
- Updated `getEntityIdFromKeys` to return properly padded entity IDs (66 characters: 0x + 64 hex) | ||
- This fixes the issue where `waitForEntityChange` would return `undefined` when using entity IDs from `getEntityIdFromKeys` | ||
- Entity IDs are now consistently padded whether they come from Torii or are generated manually | ||
- Resolves issues #484 and #485 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@dojoengine/predeployed-connector": minor | ||
"@dojoengine/create-burner": minor | ||
"@dojoengine/torii-wasm": minor | ||
"@dojoengine/core": minor | ||
"@dojoengine/create-dojo": minor | ||
"@dojoengine/grpc": minor | ||
"@dojoengine/react": minor | ||
"@dojoengine/sdk": minor | ||
"@dojoengine/state": minor | ||
"@dojoengine/torii-client": minor | ||
"@dojoengine/utils": minor | ||
"@dojoengine/utils-wasm": minor | ||
--- | ||
|
||
chore: bump dojo.c version |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@dojoengine/predeployed-connector": minor | ||
"@dojoengine/create-burner": minor | ||
"@dojoengine/torii-client": minor | ||
"@dojoengine/create-dojo": minor | ||
"@dojoengine/torii-wasm": minor | ||
"@dojoengine/utils-wasm": minor | ||
"@dojoengine/react": minor | ||
"@dojoengine/state": minor | ||
"@dojoengine/utils": minor | ||
"@dojoengine/core": minor | ||
"@dojoengine/grpc": minor | ||
"@dojoengine/sdk": minor | ||
--- | ||
|
||
chore: bump minor version |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@dojoengine/predeployed-connector": minor | ||
"@dojoengine/create-burner": minor | ||
"@dojoengine/torii-client": minor | ||
"@dojoengine/create-dojo": minor | ||
"@dojoengine/torii-wasm": minor | ||
"@dojoengine/utils-wasm": minor | ||
"@dojoengine/react": minor | ||
"@dojoengine/state": minor | ||
"@dojoengine/utils": minor | ||
"@dojoengine/core": minor | ||
"@dojoengine/grpc": minor | ||
"@dojoengine/sdk": minor | ||
--- | ||
|
||
fix(sdk): primitive parsing |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
{ | ||
"mode": "exit", | ||
"tag": "1.7-rc", | ||
"initialVersions": { | ||
"example-node-worker": "0.0.1", | ||
"example-nodejs-bot": "0.0.0", | ||
"example-predeployed-connector": "0.0.0", | ||
"example-vanillajs-phaser-recs": "0.0.0", | ||
"example-vite-experimental-sdk": "0.0.0", | ||
"example-vite-grpc-playground": "0.0.0", | ||
"example-vite-kitchen-sink": "0.1.0", | ||
"example-vite-phaser-sdk": "1.5.4", | ||
"example-vite-react-app-recs": "0.0.1", | ||
"example-vite-react-phaser-recs": "0.1.0", | ||
"example-vite-react-pwa-recs": "0.0.1", | ||
"example-vite-react-sdk": "0.0.0", | ||
"example-vite-react-sql": "1.0.0", | ||
"example-vite-react-threejs-recs": "0.0.1", | ||
"example-vite-svelte-recs": "0.0.0", | ||
"example-vite-token-balance": "0.0.0", | ||
"example-vue-app-recs": "0.0.0", | ||
"@dojoengine/core": "1.7.0-preview.3", | ||
"@dojoengine/create-burner": "1.7.0-preview.3", | ||
"@dojoengine/create-dojo": "1.7.0-preview.3", | ||
"@dojoengine/grpc": "0.1.0-preview.3", | ||
"@dojoengine/predeployed-connector": "1.7.0-preview.3", | ||
"@dojoengine/react": "1.7.0-preview.4", | ||
"@dojoengine/sdk": "1.7.0-preview.4", | ||
"@dojoengine/state": "1.7.0-preview.3", | ||
"@dojoengine/torii-client": "1.7.0-preview.3", | ||
"@dojoengine/torii-wasm": "1.7.0-preview.3", | ||
"@dojoengine/utils": "1.7.0-preview.4", | ||
"@dojoengine/utils-wasm": "1.7.0-preview.3" | ||
}, | ||
"changesets": [ | ||
"fifty-moons-film", | ||
"huge-paths-switch", | ||
"orange-points-prove", | ||
"plenty-women-read", | ||
"smooth-dragons-write", | ||
"tiny-suns-read" | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@dojoengine/predeployed-connector": minor | ||
"@dojoengine/create-burner": minor | ||
"@dojoengine/torii-wasm": minor | ||
"@dojoengine/core": minor | ||
"@dojoengine/create-dojo": minor | ||
"@dojoengine/grpc": minor | ||
"@dojoengine/react": minor | ||
"@dojoengine/sdk": minor | ||
"@dojoengine/state": minor | ||
"@dojoengine/torii-client": minor | ||
"@dojoengine/utils": minor | ||
"@dojoengine/utils-wasm": minor | ||
--- | ||
|
||
chore: bump starknet versions |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
"@dojoengine/predeployed-connector": minor | ||
"@dojoengine/create-burner": minor | ||
"@dojoengine/torii-client": minor | ||
"@dojoengine/create-dojo": minor | ||
"@dojoengine/torii-wasm": minor | ||
"@dojoengine/utils-wasm": minor | ||
"@dojoengine/react": minor | ||
"@dojoengine/state": minor | ||
"@dojoengine/utils": minor | ||
"@dojoengine/core": minor | ||
"@dojoengine/grpc": minor | ||
"@dojoengine/sdk": minor | ||
--- | ||
|
||
fix(sdk): ensure entityIds are properly padded |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -77,11 +77,11 @@ export async function setup({ ...config }: Config) { | |||||||||||||||||||||||||||||||||||||||||
let burnerManager = null; | ||||||||||||||||||||||||||||||||||||||||||
try { | ||||||||||||||||||||||||||||||||||||||||||
burnerManager = new BurnerManager({ | ||||||||||||||||||||||||||||||||||||||||||
masterAccount: new Account( | ||||||||||||||||||||||||||||||||||||||||||
rpcProvider, | ||||||||||||||||||||||||||||||||||||||||||
config.masterAddress, | ||||||||||||||||||||||||||||||||||||||||||
config.masterPrivateKey | ||||||||||||||||||||||||||||||||||||||||||
), | ||||||||||||||||||||||||||||||||||||||||||
masterAccount: new Account({ | ||||||||||||||||||||||||||||||||||||||||||
provider: rpcProvider, | ||||||||||||||||||||||||||||||||||||||||||
address: config.masterAddress, | ||||||||||||||||||||||||||||||||||||||||||
signer: config.masterPrivateKey, | ||||||||||||||||||||||||||||||||||||||||||
}), | ||||||||||||||||||||||||||||||||||||||||||
feeTokenAddress: config.feeTokenAddress, | ||||||||||||||||||||||||||||||||||||||||||
Comment on lines
79
to
85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Explicitly set cairoVersion on Account to avoid defaults drift. Passing only signer may default to a different Cairo/tx version under newer starknet.js. Safer to pin Cairo 1 for these examples. Apply: - masterAccount: new Account({
- provider: rpcProvider,
- address: config.masterAddress,
- signer: config.masterPrivateKey,
- }),
+ masterAccount: new Account({
+ provider: rpcProvider,
+ address: config.masterAddress,
+ signer: config.masterPrivateKey,
+ cairoVersion: "1",
+ }), 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||||||||||||||||||||
accountClassHash: config.accountClassHash, | ||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -55,12 +55,11 @@ export const getAccount = async (nodeUrl: string) => { | |||||||||||||||||||||||||||||||||
if (!address) { | ||||||||||||||||||||||||||||||||||
return null; | ||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||
const account = new Account( | ||||||||||||||||||||||||||||||||||
const account = new Account({ | ||||||||||||||||||||||||||||||||||
provider, | ||||||||||||||||||||||||||||||||||
address, | ||||||||||||||||||||||||||||||||||
burners[address].privateKey, | ||||||||||||||||||||||||||||||||||
"1" | ||||||||||||||||||||||||||||||||||
); | ||||||||||||||||||||||||||||||||||
signer: burners[address].privateKey, | ||||||||||||||||||||||||||||||||||
}); | ||||||||||||||||||||||||||||||||||
return account; | ||||||||||||||||||||||||||||||||||
Comment on lines
+58
to
63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Pin Cairo 1 in Account constructor. Avoid relying on library defaults; match the classHash you deploy. - const account = new Account({
- provider,
- address,
- signer: burners[address].privateKey,
- });
+ const account = new Account({
+ provider,
+ address,
+ signer: burners[address].privateKey,
+ cairoVersion: "1",
+ }); 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||||||||||||
}; | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
|
@@ -80,7 +79,7 @@ export const createAccount = async ({ | |||||||||||||||||||||||||||||||||
CallData.compile({ publicKey }), | ||||||||||||||||||||||||||||||||||
0 | ||||||||||||||||||||||||||||||||||
); | ||||||||||||||||||||||||||||||||||
const account = new Account(provider, address, privateKey, "1"); | ||||||||||||||||||||||||||||||||||
const account = new Account({ provider, address, signer: privateKey }); | ||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Pin Cairo 1 for the newly created account as well. - const account = new Account({ provider, address, signer: privateKey });
+ const account = new Account({
+ provider,
+ address,
+ signer: privateKey,
+ cairoVersion: "1",
+ }); 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||||||||||||
const { transaction_hash } = await account.deployAccount({ | ||||||||||||||||||||||||||||||||||
classHash, | ||||||||||||||||||||||||||||||||||
constructorCalldata: CallData.compile({ publicKey }), | ||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Validate semver bump levels across packages
Most entries are marked "minor" while the body calls out a fix. Confirm whether any user‑visible features or API changes justify minor bumps; otherwise prefer "patch" to avoid unnecessary version churn.
Run to list public API changes since last tag:
🏁 Script executed:
Length of output: 209241
Switch bumps from minor to patch
All this changeset contains are bug fixes with no new public APIs—update the version bumps in
.changeset/tiny-suns-read.md
(lines 2–13) fromminor
topatch
.🤖 Prompt for AI Agents