Add composer support #2
Conversation
|
I must admit I prefer this version ;) |
|
Cool. Can you create a tag for this version (just anything like "v0.9" will do), then make sure you push the tag to github ( Then submit this to packagist.org so I can list it as a dependency for dompdf :) |
|
Hey, I added it to packagist https://packagist.org/packages/phenx/php-font-lib after making the tag: https://github.com/PhenX/php-font-lib/tags |
|
You tagged the version before by recent pull request (so packagist can't see the composer.json file). Can you |
|
No I tagged it after your pull request (39a6d59). But it looks like tagging only makes a zip. |
|
No, you tagged it correctly, but your tag points to 6346e06 (see here: https://github.com/PhenX/php-font-lib/commits/0.1 ) You submitted it to packagist correctly. The only problem is that packagist can only see the "dev-master" branch, since the 0.1 tag doesn't contain a composer.json file. If you want to give me access to the repo I'm happy to fix up the tag for you. Otherwise you just need to make sure your local git repo is at the correct commit (check with "git log") before you run "git tag". Also don't try to re-tag 0.1, that will make a mess since that tag is already public and re-writing history is bad. Just call the new tag 0.1.1 or something :) |
|
Oh, sh** ! :) I didn't sync my local repo before making the tag ! I'm fixing it. |
… of type int is deprecated in FontLib\BinaryStream.php on line 123 Unknown: fseek(): Passing null to parameter dompdf#2 ($offset) of type int is deprecated in FontLib\BinaryStream.php on line 123
I've added a basic composer.json to this project so that we can list it as a dependency of DOMPDF.
You can now generate a valid
autoload.phpfile by runningcomposer updatein the package root. Originally I went through the existing classes and removed all therequire_oncestatements, but I decided it's probably better to leave them there for now, to support anyone still manually including this package.