NFC: green tea test for EEPROM driver #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-szczepanek-arm
changed the title
donatieng
requested changes
Aug 22, 2018
TESTS/nfc/eeprom/main.cpp
Outdated
|
|
||
| /* WRITE_READ_TEST */ | ||
| { START_SESSION, WRITE_SIZE_4, WRITE_4_BYTES, READ_4_BYTES, WRITE_2_BYTES, | ||
| READ_4_BYTES_MIXED, END_SESSION, TERMINATE }, |
There was a problem hiding this comment.
Here and in the erase test, you write the size but don't read it back?
There was a problem hiding this comment.
yes, size changes are tested elsewhere, this size write is part of the writing of bytes which is tested by reading them back, no harm checking the size though
|
@donatieng does this resolve your request? |
donatieng
approved these changes
Aug 23, 2018
donatieng
pushed a commit
that referenced
this pull request
Nov 19, 2018
Add default pin macro names and default pins on select set of boards
donatieng
pushed a commit
that referenced
this pull request
Nov 19, 2018
Add macros for default pin names
pan-
added a commit
that referenced
this pull request
Nov 28, 2018
Last bit of PAL extended advertising implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Green tea test for EEPROM drivers, testing all common operations but not doing any stress testing or testing of large data (I'm waiting for Don's code for that to avoid repeating the same logic).
Pull request type