-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed some minor bugs in HybridHelper #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bertyhell
commented
Sep 12, 2017
- Fix semicolons in interface
- Import angular
- Unify name: componentSelector in the method: downgradeComponent in class and interface
- Minor layout improvements
also: unify name: componentSelector in the method: downgradeComponent in class and interface
options = options || {}; | ||
const inputs = options.inputs || []; | ||
const outputs = options.outputs || []; | ||
const component = componentClass; | ||
|
||
angular.module(moduleName).directive(componentName, downgradeComponent({ | ||
component, inputs, outputs | ||
angular.module(moduleName).directive(componentSelector, downgradeComponent({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the componentSelector. Selector has a dash.
I prefer to be consistence with the AngularJS code.
Please revert this change and I will merge this pull request.
The definition of the directive function in the AngularJS code:
/** * @ngdoc method * @name angular.Module#directive * @module ng * @param {string|Object} name Directive name, or an object map of directives where the * keys are the names and the values are the factories. * @param {Function} directiveFactory Factory function for creating new instance of * directives. * @description * See {@link ng.$compileProvider#directive $compileProvider.directive()}. */ directive: invokeLaterAndSetModuleName('$compileProvider', 'directive'),
I'm to lazy to make a pull request, but there are a few bugs in here First of all, the import of angular is missing Here is the full code on which my editor and webpack no longer fails.
|