1.13.1 -> 1.13.2 removes comments from schema

[SimenB]

Describe the bug
Comments from the schema are gone in the generated code.

To Reproduce
Steps to reproduce the behavior:

1. My GraphQL schema:

type Query {
  # A name!
  name: String!
}

2. My GraphQL operations:

# none

3. My codegen.yml config file:

generates:
  ./gqltypes.ts:
    schema: ./schema.graphql
    plugins:
      - 'typescript'

Expected behavior
1.13.1 generates comments

export type Maybe<T> = T | null;
/** All built-in and custom scalars, mapped to their actual values */
export type Scalars = {
  ID: string;
  String: string;
  Boolean: boolean;
  Int: number;
  Float: number;
};

export type Query = {
   __typename?: 'Query';
  /** A name! */
  name: Scalars['String'];
};

1.13.2 does not

diff --git i/gqltypes.ts w/gqltypes.ts
index 41d3dfebf..3172daf0e 100644
--- i/gqltypes.ts
+++ w/gqltypes.ts
@@ -10,6 +10,5 @@ export type Scalars = {
 
 export type Query = {
    __typename?: 'Query';
-  /** A name! */
   name: Scalars['String'];
 };

Environment:

• OS: macOS
• @graphql-codegen/...: 1.13.2
• NodeJS: 12.16.1

Additional context

[ardatan]

Could you add commentDescriptions option like below and try again?

generates:
  ./gqltypes.ts:
    schema: 
        - ./schema.graphql:
              commentDescriptions: true
    plugins:
      - 'typescript'

[SimenB]

That makes no difference

[ardatan]

In GraphQL Spec, comments with # are deprecated so you need to use """ descriptions instead.
You can see here;
graphql/graphql-js#927

Not sure if we change the behavior because supporting both descriptions and comments might break things. @dotansimha What do you think?

Maybe the following would work because we only removed commentDescriptions which can be added in those ways I already showed you.

generates:
  ./gqltypes.ts:
    schema: ./schema.graphql:
    plugins:
      - 'typescript'
    config:
       commentDescriptions: true

[SimenB]

Aha, I didn't know that, thanks for the link! I'd still consider it worth pointing out in the changelog though. The only close to it is

Fix issues with missing descriptions and comments when schema is loaded from a url source (#3804 )

We've migrated to using """ now, so this is solved for us. But again, it should be noted in the changelog and not silently dropped