Queue implementation #373
Queue implementation #373
Conversation
Signed-off-by: sergiu <[email protected]>
Signed-off-by: sergiu <[email protected]>
composer.json
Outdated
| }, | ||
| "require": { | ||
| "php": "~8.2.0 || ~8.3.0", | ||
| "ext-sockets": "*", |
There was a problem hiding this comment.
what is with those socket packages and extensions ?
not a good idea to add it to the default admin ...
there is nothing built in ?
config/config.php
Outdated
| Core\Security\ConfigProvider::class, | ||
| Core\Setting\ConfigProvider::class, | ||
| Core\User\ConfigProvider::class, | ||
| Core\NotificationSystem\ConfigProvider::class, |
There was a problem hiding this comment.
can we load this dynamically ?
Only if there is something about that in local.php ?
There was a problem hiding this comment.
@arhimede
We sure we want this in Core? Or even implemented and ready-to-use in our projects?
With this we force devs to use Queue even for tiny tasks of sending an email.
To me adding this complexity is similiar to moving Core to a separate repo and using it as a submodule (which we concurred that is probably too much) because it requires devs to set up another project they might not need in the first place.
Yeah, i know |
|
Maybe a simple tutorial |
Signed-off-by: sergiu <[email protected]>
Replaced the built it function to send emails with QUEUE implementation.