Add section about browser tabs sleeping #22773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
davidfowl,
kg,
guardrex,
Rick-Anderson and
bradygaster
guardrex
approved these changes
Jul 19, 2021
bradygaster
approved these changes
Jul 19, 2021
Rick-Anderson
approved these changes
Jul 19, 2021
Co-authored-by: Rick Anderson <[email protected]> Co-authored-by: Luke Latham <[email protected]>
BrennanConroy
commented
Jul 19, 2021
BrennanConroy
commented
Jul 19, 2021
BrennanConroy
commented
Jul 19, 2021
BrennanConroy
commented
Jul 19, 2021
bradygaster
approved these changes
Jul 28, 2021
BrennanConroy
commented
Jul 28, 2021
Co-authored-by: Rick Anderson <[email protected]>
BrennanConroy
commented
Jul 28, 2021
BrennanConroy
commented
Jul 28, 2021
BrennanConroy
commented
Jul 28, 2021
|
|
||
| <!-- This heading is used by code in the SignalR Typescript client, do not rename or remove without considering the impacts there --> | ||
|
|
||
| <h2 id="bsleep">Browser sleeping tab</h2> |
There was a problem hiding this comment.
@Rick-Anderson @guardrex Can you give this a quick final once over and then I'll merge
There was a problem hiding this comment.
I defer to @Rick-Anderson on this. I only use this when I must; and I think with version by file now 🎉, it will only be needed in Blazor docs that use a WASM/Server pivot with duplicate headings.
Rick-Anderson
approved these changes
Jul 28, 2021
Co-authored-by: Rick Anderson <[email protected]>
|
@BrennanConroy ... Your JS ... two-spaces tho for the indents is our standard AFAIK. |
|
Toooo late! Oh, well. I think actually that it probably isn't completely standardized around the doc set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal review link