-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Improve SignalR Redis Cluster section #28310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VilleKylmamaa ... I'll perform an edit pass after technical review. Done!
Removed Redis Sentinel suggestion because of uncertainty whether it is supported. You can trigger Sentinel mode in StackExchange.Redis by adding a service name to the connection string (https://stackexchange.github.io/StackExchange.Redis/Configuration), but I am unsure if it works with SignalR.
I removed the Redis Sentinel suggestion because of uncertainty whether it is supported out of the box. You can trigger Sentinel mode in StackExchange.Redis by adding a service name to the connection string (https://stackexchange.github.io/StackExchange.Redis/Configuration), but I am unsure if it works with SignalR. I failed to make it work properly in quick testing. It should be confirmed to work if it is to be added in the documentation. |
@VilleKylmamaa ... See if my updates broke any of the meaning. |
@guardrex The edits are good 👍 |
Thanks @VilleKylmamaa ... We'll stand-by for a bit until @BrennanConroy is free to take a look. |
Let's see how this looks ...
|
Co-authored-by: Brennan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SignalR Redis backplane documentation informs about the trade-off that increasing the number of nodes in a Redis Cluster decreases the message throughput of the backplane (source video, and source slides).
Also mention that in the SignalR app, all the Redis nodes should be included in the Redis connection string or added as
EndPoints
in theConfigurationOptions
object.Reference issue: dotnet/aspnetcore#46408