Skip to content

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 6, 2025

Fixes #34658

@danroth27 ... The PU PR looks like it has a NIT 😈. The record there is ...

record Person(int PersonId, string firstName, string lastName, DateOnly BirthDate);

Cross-ref: https://github.com/dotnet/aspnetcore/pull/59901/files

... and the C# record guidance never does that given that these are properties, thus they should be Pascal case, which I'm going to do on this PR for the doc example.

Do you want me to open a PU issue to update the SampleQuickGridComponent component?

UPDATE (2/11): I'm going to go ahead with this. Let me know if you have a change request. 👂 It will be added to the What's New article on a separate PR shortly.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/components/quickgrid.md aspnetcore/blazor/components/quickgrid

@guardrex guardrex self-assigned this Feb 6, 2025
@guardrex guardrex requested a review from danroth27 February 6, 2025 16:01
@guardrex guardrex merged commit 886d073 into main Feb 11, 2025
3 checks passed
@guardrex guardrex deleted the guardrex-patch-4 branch February 11, 2025 22:27
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QuickGrid RowClass parameter

2 participants