Skip to content

remove PDF and MAP files #9189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

remove PDF and MAP files #9189

wants to merge 3 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Oct 24, 2018 •
edited
Loading

Fixes #9182

@Rick-Anderson Rick-Anderson changed the title remove PDFs remove PDF and MAP files Oct 24, 2018
@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented Oct 24, 2018 •
edited
Loading

@scottaddie I removed all the map files and tested a couple apps. They seem to work OK without them. Not sure why bootstrap need map files.

Edit This SO link explains why they're added. Since we're not debugging in production, we don't need them.

scottaddie
scottaddie approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the purposes of the docs, I see no reason why the source map files would be needed. That's a nice improvement!

@Rick-Anderson
Copy link
Contributor Author

@scottaddie I found an external source for the PDFs so I think it might be easier to close this PR and start over (with links to the external PDFs)

@scottaddie
Copy link
Member

@Rick-Anderson Do whatever's the easiest.

@Rick-Anderson Rick-Anderson deleted the remove/pdf/ra branch October 25, 2018 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaddie scottaddie scottaddie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rick-Anderson @scottaddie