Skip to content

UnresolvedDiagnoser needs to have an Id as well #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

UnresolvedDiagnoser needs to have an Id as well #2251

merged 1 commit into from
Jan 20, 2023

Conversation

adamsitnik
Copy link
Member

A fix for bug reported offline by @KrzysztofCwalina

otherwise CompositeDiagnoser.DisplayResults throws:

BenchmarkDotNet/src/BenchmarkDotNet/Diagnosers/CompositeDiagnoser.cs

Line 47 in e715d5b

logger.WriteLineHeader($"// * Diagnostic Output - {diagnoser.Ids.Single()} *");

@adamsitnik adamsitnik added this to the v0.13.5 milestone Jan 19, 2023
@adamsitnik adamsitnik merged commit a992b57 into master Jan 20, 2023
@adamsitnik adamsitnik deleted the unresolvedDiagnoser branch January 20, 2023 07:58
@timcassell timcassell mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area:Diagnosers
Projects
None yet
Milestone
v0.13.5
Development

Successfully merging this pull request may close these issues.
1 participant
@adamsitnik