Document breaking changes for complex types in EF Core 10.0 #5113

Copilot · 2025-09-26T20:06:34Z

This PR documents breaking changes for EF Core 10.0 related to complex types.

Breaking Changes Documented

Complex Types (#4970)

Column name uniquification: Complex type column names are now uniquified by appending a number if another column with the same name exists, instead of silently sharing columns between properties
IDiscriminatorPropertySetConvention signature change: The ProcessDiscriminatorPropertySet method now takes IConventionTypeBaseBuilder instead of IConventionEntityTypeBuilder
Nested complex type column naming: Properties on nested complex types now use the full path to the property as part of the column name instead of just the declaring type

Changes Made

Added breaking change entries to EF Core 10.0 breaking changes documentation for complex types
Moved value converter compiled models breaking change to EF Core 9.0 documentation (where it was actually introduced)
Updated compiled models limitations section with value converter constraints
Provided clear migration guidance and examples for all breaking changes
Addressed all review feedback for accuracy and clarity

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…els with value converters Co-authored-by: AndriySvyryd <[email protected]>

entity-framework/core/performance/advanced-performance-topics.md

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

samples/core/Miscellaneous/CompiledModels/ValueConverterSample.cs

…sections Co-authored-by: AndriySvyryd <[email protected]>

entity-framework/core/performance/advanced-performance-topics.md

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

…, reorganize sections Co-authored-by: AndriySvyryd <[email protected]>

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

Co-authored-by: AndriySvyryd <[email protected]>

AndriySvyryd · 2025-09-26T23:37:31Z

@copilot Update the description with a short summary and reference the fixed issues dotnet/efcore#35033 and #4970

Copilot · 2025-09-26T23:39:03Z

@copilot Update the description with a short summary and reference the fixed issues dotnet/efcore#35033 and #4970

Updated the PR description with a short summary of the breaking changes documented and added references to the fixed issues #35033 and #4970.

roji · 2025-09-27T16:55:24Z

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

+{
+    public static readonly BooleanToCharConverter Default = new();
+
+    public BooleanToCharConverter()


nit: maybe modernize the code sample a bit, with a primary constructor, expression-bodied methods below?

@copilot modernize the code sample a bit, with a primary constructor and expression-bodied methods

Modernized the code sample to use a primary constructor and expression-bodied methods for the conversion methods. (1d1a23e)

roji · 2025-09-30T11:17:45Z

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

 |:--------------------------------------------------------------------------------------------------------------- | -----------|
 | [SQL Server json data type used by default on Azure SQL and compatibility level 170](#sqlserver-json-data-type) | Low        |
 | [ExecuteUpdateAsync now accepts a regular, non-expression lambda](#ExecuteUpdateAsync-lambda)                   | Low        |
+| [Compiled models now throw exception for value converters with private methods](#compiled-model-private-methods) | Low        |


@copilot please align indentation here so that the markdown table is formatted correctly/consistently.

Fixed the markdown table indentation alignment. (94791e4)

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

roji · 2025-09-30T11:23:48Z

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

+
+#### Old behavior
+
+Previously, when mapping complex types to table columns, if multiple properties in different complex types had the same column name, they would silently share the same column.


How does this relate to the breaking change just below - are they dups? In other words, if the full path is now used (the change below), how is it possible to for multiple properties in different complex types to have the same column name (i.e. when would appending the number be necessary)?

It's less likely, but still possible if the user explicitly set the column name on one that matches the default column name of the other.

Co-authored-by: roji <[email protected]>

roji · 2025-09-30T11:27:03Z

@AndriySvyryd am slightly confused by certain things here (see comments) but I'm sure it's my misunderstanding etc.

…methods Co-authored-by: AndriySvyryd <[email protected]>

Co-authored-by: AndriySvyryd <[email protected]>

Initial plan

ab769de

Copilot AI assigned Copilot and AndriySvyryd Sep 26, 2025

Copilot started work on behalf of AndriySvyryd September 26, 2025 20:06 View session

Add breaking changes documentation for complex types and compiled mod…

76f1be5

…els with value converters Co-authored-by: AndriySvyryd <[email protected]>

Copilot AI changed the title ~~[WIP] Fix these issues @dotnet/EntityFramework.Docs/issues/4970 @dotnet/efcore/issues/35033~~ Document breaking changes for complex types and compiled models in EF Core 10.0 Sep 26, 2025

Copilot finished work on behalf of AndriySvyryd September 26, 2025 20:21

Copilot AI requested a review from AndriySvyryd September 26, 2025 20:21

AndriySvyryd reviewed Sep 26, 2025

View reviewed changes

Copilot started work on behalf of AndriySvyryd September 26, 2025 22:32 View session

Address review feedback: fix breaking changes and remove unnecessary …

829de18

…sections Co-authored-by: AndriySvyryd <[email protected]>

Copilot AI requested a review from AndriySvyryd September 26, 2025 22:37

Copilot finished work on behalf of AndriySvyryd September 26, 2025 22:37

AndriySvyryd reviewed Sep 26, 2025

View reviewed changes

Copilot started work on behalf of AndriySvyryd September 26, 2025 23:13 View session

Address additional review feedback: remove links, update descriptions…

71791b6

…, reorganize sections Co-authored-by: AndriySvyryd <[email protected]>

Copilot AI requested a review from AndriySvyryd September 26, 2025 23:19

Copilot finished work on behalf of AndriySvyryd September 26, 2025 23:19

AndriySvyryd reviewed Sep 26, 2025

View reviewed changes

entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md Outdated Show resolved Hide resolved

Copilot started work on behalf of AndriySvyryd September 26, 2025 23:23 View session

Update nested complex type example to use clearer naming

e6cca70

Co-authored-by: AndriySvyryd <[email protected]>

Copilot AI requested a review from AndriySvyryd September 26, 2025 23:26

Copilot finished work on behalf of AndriySvyryd September 26, 2025 23:26

AndriySvyryd approved these changes Sep 26, 2025

View reviewed changes

AndriySvyryd marked this pull request as ready for review September 26, 2025 23:36

Copilot started work on behalf of AndriySvyryd September 26, 2025 23:37 View session

Copilot AI requested a review from AndriySvyryd September 26, 2025 23:39

Copilot finished work on behalf of AndriySvyryd September 26, 2025 23:39

AndriySvyryd requested a review from a team September 26, 2025 23:51

roji approved these changes Sep 30, 2025

View reviewed changes

Copilot started work on behalf of roji September 30, 2025 11:25 View session

Fix markdown table indentation alignment

94791e4

Co-authored-by: roji <[email protected]>

Copilot AI requested a review from roji September 30, 2025 11:28

Copilot finished work on behalf of roji September 30, 2025 11:28

Copilot started work on behalf of AndriySvyryd September 30, 2025 16:36 View session

Modernize code sample with primary constructor and expression-bodied …

1d1a23e

…methods Co-authored-by: AndriySvyryd <[email protected]>

Copilot finished work on behalf of AndriySvyryd September 30, 2025 16:38

Copilot started work on behalf of AndriySvyryd September 30, 2025 16:52 View session

AndriySvyryd unassigned AndriySvyryd and Copilot Sep 30, 2025

Move value converter breaking change to EF Core 9.0 documentation

c98638c

Co-authored-by: AndriySvyryd <[email protected]>

Copilot AI changed the title ~~Document breaking changes for complex types and compiled models in EF Core 10.0~~ Document breaking changes for complex types in EF Core 10.0 Sep 30, 2025

Copilot finished work on behalf of AndriySvyryd September 30, 2025 16:56

AndriySvyryd merged commit 0ae6eac into live Sep 30, 2025
6 checks passed

AndriySvyryd deleted the copilot/fix-a278b454-18f8-429a-a431-75b87ce795c2 branch September 30, 2025 17:53


		#### Old behavior

		Previously, when mapping complex types to table columns, if multiple properties in different complex types had the same column name, they would silently share the same column.

Document breaking changes for complex types in EF Core 10.0 #5113

Document breaking changes for complex types in EF Core 10.0 #5113

Uh oh!

Conversation

Copilot AI commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Changes Documented

Complex Types (#4970)

Changes Made

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndriySvyryd commented Sep 26, 2025

Uh oh!

Copilot AI commented Sep 26, 2025

Uh oh!

roji Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

AndriySvyryd Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

roji Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

roji Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

AndriySvyryd Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

roji commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 26, 2025 •

edited

Loading