Enable PoolBlockingPeriod for .NET Standard + expose GetColumnSchema #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
saurabh500,
David-Engel,
johnnypham,
JRahnama and
DavoudEshtehari
cheenamalhotra
force-pushed
the
exposeMissingAPIs
branch
from
d6d4bb1 to
92f03b1
Compare
David-Engel
reviewed
Jul 21, 2021
cheenamalhotra
added
the
Public API 🆕
johnnypham
approved these changes
Aug 11, 2021
JRahnama
approved these changes
Aug 13, 2021
DavoudEshtehari
approved these changes
Aug 18, 2021
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.NetCoreApp.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains below changes:
Below API was not exposed in .NET Standard DLLs, even though functionality was available.
Pool Blocking Period has no API limitations in .NET Standard 2.0 and 2.1, tested using "-p:ReferenceType=NetStandard", hence enabling it here. Would appreciate feedback/concerns on this change.
cc @saurabh500 @David-Engel