Skip to content

Fix regression in CancelAsyncConnections test using Native SNI #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix regression in CancelAsyncConnections test using Native SNI #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2527,7 +2527,8 @@ internal void ReadSni(TaskCompletionSource<object> completion)
// Evaluate this condition for MANAGED_SNI. This may not be needed because the network call is happening Async and only the callback can receive a success.
ReadAsyncCallback(IntPtr.Zero, readPacket, 0);

if (!IsPacketEmpty(readPacket))
// Only release packet for Managed SNI as for Native SNI packet is released in finally block.
if (TdsParserStateObjectFactory.UseManagedSNI && !IsPacketEmpty(readPacket))
{
ReleasePacket(readPacket);
}
Expand Down