Skip to content

Fix | Remove Visual Studio designer attributes #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2021
Merged

Fix | Remove Visual Studio designer attributes #1296

merged 3 commits into from
Sep 29, 2021

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented Sep 28, 2021 •
edited
Loading

"Microsoft.VSDesigner" hasn't supported Microsoft.Data.SqlClient yet. And using it causes some exceptions on VS and the release process.

Similar issue #1110

@DavoudEshtehari DavoudEshtehari added this to the 4.0.0-preview3 milestone Sep 28, 2021
@JRahnama
Copy link
Contributor

JRahnama commented Sep 28, 2021 •
edited
Loading

NIT: what about the constant defined in the internal static class AssemblyRef

namespace Microsoft.Data.SqlClient
{
    internal static class AssemblyRef
    {
        internal const string MicrosoftVSDesigner = "Microsoft.VSDesigner, Version=10.0.0.0, Culture=neutral, 
    }
}

Should we take it out that constant string as well?

cheenamalhotra
cheenamalhotra reviewed Sep 28, 2021
View reviewed changes
@DavoudEshtehari DavoudEshtehari merged commit c8c8fe4 into dotnet:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+2 more reviewers

@lcheunglci lcheunglci lcheunglci approved these changes

@JRahnama JRahnama JRahnama approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.
4 participants
@DavoudEshtehari @JRahnama @cheenamalhotra @lcheunglci