-
Notifications
You must be signed in to change notification settings - Fork 314
Add | Local DB support for ARM64 and Common Code for LocalDB #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kaur-Parminder
wants to merge
19
commits into
dotnet:main
from
Kaur-Parminder:LocalDBSupportForARM64andCodeMerge
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
142c968
LocalDB Common Managed Code and ARM Support (with LocalDB.exe)
Kaur-Parminder 42b359c
moved LocalDB instance creation in SqlInternalConnectionTds, removed …
Kaur-Parminder 8bdb578
Apply suggestions from code review
Kaur-Parminder cb876f3
review comments
Kaur-Parminder cc024a3
review comments
Kaur-Parminder e6cd127
ExtendedServerName for DataSource, LocalDB to use Formatted string
Kaur-Parminder c0c061f
changed exception to SQLExceptions for DataSource invalid connection …
Kaur-Parminder da4bd01
removed unused localdberror variable, changed error class to min_error
Kaur-Parminder f595abb
Suggestions and minor tweaks
David-Engel 91b92c6
Formatting
David-Engel 1c26344
review comments
Kaur-Parminder 053efdf
resolved conflicts
Kaur-Parminder 045c859
localdb to use only named pipe
Kaur-Parminder d91a7b6
Merge branch 'main' into LocalDBSupportForARM64andCodeMerge
Kaur-Parminder 6cd4900
resolving conflict
Kaur-Parminder ba2dbf3
Add Platform not supported test
Kaur-Parminder 83ce1b3
removing GetLocalDbNamedPipe method from static properties
Kaur-Parminder 00413d4
errors from sqllocaldb.exe
Kaur-Parminder 9e561a0
revert autogenerated change- Strings.Designer to keep using MDS.strings
Kaur-Parminder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/LocalDB.Unix.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System; | ||
using Microsoft.Data.ProviderBase; | ||
using Microsoft.Data.Common; | ||
|
||
namespace Microsoft.Data.SqlClient | ||
{ | ||
internal class LocalDB | ||
{ | ||
internal static string GetLocalDBConnectionString(string localDbInstance) | ||
{ | ||
throw ADP.LocalDBNotSUpportedException(); | ||
} | ||
|
||
internal static string GetLocalDBDataSource(string fullServerName, TimeoutTimer timeout) | ||
{ | ||
throw ADP.LocalDBNotSUpportedException(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 0 additions & 123 deletions
123
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/LocalDBAPI.Common.cs
This file was deleted.
Oops, something went wrong.
41 changes: 0 additions & 41 deletions
41
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/LocalDBAPI.Windows.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/LocalDB.Unix.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.