Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

arellegue · 2023-06-08T19:34:32Z

fixes #1894
Added type converter for SqlConnectionEncryptOption.

…t string Encrypt option into SqlConnectionEncryptionOption type.

...Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOptionConverter.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

codecov · 2023-06-09T18:37:32Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.80 ⚠️

Comparison is base (288a70c) 70.68% compared to head (7415ec1) 69.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
- Coverage   70.68%   69.89%   -0.80%     
==========================================
  Files         305      306       +1     
  Lines       61819    61956     +137     
==========================================
- Hits        43699    43302     -397     
- Misses      18120    18654     +534

Flag	Coverage Δ
addons	`92.88% <ø> (ø)`
netcore	`73.35% <100.00%> (-0.02%)`	⬇️
netfx	`68.17% <100.00%> (-1.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...osoft/Data/SqlClient/SqlConnectionEncryptOption.cs	`93.33% <ø> (ø)`
...a/SqlClient/SqlConnectionEncryptOptionConverter.cs	`100.00% <100.00%> (ø)`

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

...Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOptionConverter.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

...Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOptionConverter.cs

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

tools/props/Versions.props

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

tools/props/Versions.props

…onStringBuilderTest.cs

…ThrowsException unit test.

DavoudEshtehari

The xml files are only required for public APIs. In this case, if SqlConnectionEncryptOptionConverter type is going to be internal, remove the xml file and inline dependencies.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

...Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOptionConverter.cs

…ptionConverter. Removed misplaced region. Removed function that is not used.

…nverter class.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs

src/Microsoft.Data.SqlClient.sln

…vertFrom test returns false.

This reverts commit 06b3536.

…onvertTo returns false.

…vertTo tests passed or failed.

…nnectionEncryptOption (dotnet#2057) Ports [dotnet#2057](dotnet#2057)

arellegue added 4 commits June 8, 2023 10:43

Add SqlConnectionEncryptOptionConverter class which is used to conver…

5c505a1

…t string Encrypt option into SqlConnectionEncryptionOption type.

Merge branch 'main' of https://github.com/arellegue/SqlClient

9b9af7e

Removed added blank line.

4ebaabd

Removed redundant InLineData from ConnectionStringFromJsonTests.

39a7ea8

arellegue added the 🐛 Bug! label Jun 8, 2023

arellegue added this to the 5.2.0-preview2 milestone Jun 8, 2023

JRahnama reviewed Jun 8, 2023

View reviewed changes

JRahnama modified the milestones: 5.2.0-preview2, 5.2.0-preview3 Jun 8, 2023

Fix issues found in PR request.

0a0768e

JRahnama requested review from DavoudEshtehari, David-Engel and Kaur-Parminder June 13, 2023 16:47

DavoudEshtehari changed the title ~~Sql connection encrypt option~~ Fix | Adding type convertor support for SqlConnectionEncryptOption Jun 13, 2023

DavoudEshtehari reviewed Jun 15, 2023

View reviewed changes

arellegue added 2 commits June 15, 2023 08:47

Changed SqlConnectionEnryptOptionConverter from public to internal.

ab6a469

Applied Davoud's suggestions for changes.

892625c

DavoudEshtehari reviewed Jun 16, 2023

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs Outdated Show resolved Hide resolved

tools/props/Versions.props Outdated Show resolved Hide resolved

DavoudEshtehari and others added 5 commits June 15, 2023 18:46

Update src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnecti…

789670e

…onStringBuilderTest.cs

Update tools/props/Versions.props

5455314

Add more SqlConnectionEncryptOptionConverter unit tests.

e07547a

Add assessment of exception thrown in ExecuteConnectionStringFromJson…

7197981

…ThrowsException unit test.

Added blank line.

d7f0058

arellegue requested review from JRahnama and DavoudEshtehari June 19, 2023 23:29

DavoudEshtehari reviewed Jun 19, 2023

View reviewed changes

DavoudEshtehari and others added 3 commits June 19, 2023 17:06

Apply suggestions from code review

7dee649

Removed unnecessary XML file for internal class SqlConnectionEncryptO…

c9d115c

…ptionConverter. Removed misplaced region. Removed function that is not used.

Use ADP.ConvertFailed helper function in SqlConnectionEncryptOptionCo…

4b5f86d

…nverter class.

Resolved merged conflict.

14ac22f

arellegue requested a review from DavoudEshtehari June 20, 2023 17:01

Apply suggestions from code review

9a42b07

DavoudEshtehari reviewed Jun 20, 2023

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionStringBuilderTest.cs Outdated Show resolved Hide resolved

JRahnama reviewed Jun 23, 2023

View reviewed changes

src/Microsoft.Data.SqlClient.sln Outdated Show resolved Hide resolved

arellegue requested review from JRahnama and DavoudEshtehari June 28, 2023 18:25

DavoudEshtehari reviewed Jun 28, 2023

View reviewed changes

src/Microsoft.Data.SqlClient.sln Outdated Show resolved Hide resolved

arellegue added 8 commits June 28, 2023 12:11

Add message to show more information if CanCanConvert returns false.

809bbe8

Fixed grammar error in the message to show more information if CanCon…

20170ee

…vertFrom test returns false.

Removed entry for EncryptOptionConverter XML.

06b3536

Revert "Removed entry for EncryptOptionConverter XML."

99d1243

This reverts commit 06b3536.

Remove EncryptOptionConverter xml in MDS solution.

766d859

Add more messages to show more information if CanConvertFrom and CanC…

1040674

…onvertTo returns false.

Change messages to show the expections when CanConvertFrom and CanCon…

f54d699

…vertTo tests passed or failed.

Fix CanConvertTo messages.

7415ec1

DavoudEshtehari approved these changes Jun 28, 2023

View reviewed changes

JRahnama approved these changes Jul 6, 2023

View reviewed changes

Kaur-Parminder merged commit 1aa9af6 into dotnet:main Jul 6, 2023

DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Oct 25, 2023

Merged PR 4030: [5.1.2] Fix | Adding type convertor support for SqlCo…

0b51b63

…nnectionEncryptOption (dotnet#2057) Ports [dotnet#2057](dotnet#2057)

This was referenced Jul 30, 2025

Bump the nuget group with 4 updates geekswagg/CleanArchitectureWithBlazorServer#1

Open

Bump the nuget group with 1 update Tedydev-web/lms.vnMentor#2

Open

dependabot bot mentioned this pull request Aug 27, 2025

Bump Microsoft.Data.SqlClient from 5.0.1 to 5.1.3 nbarnwell/Inforigami.Regalo#29

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

Uh oh!

arellegue commented Jun 8, 2023 •

edited by JRahnama

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 9, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavoudEshtehari left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

Fix | Adding type convertor support for SqlConnectionEncryptOption #2057

Uh oh!

Conversation

arellegue commented Jun 8, 2023 • edited by JRahnama Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DavoudEshtehari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arellegue commented Jun 8, 2023 •

edited by JRahnama

Loading

codecov bot commented Jun 9, 2023 •

edited

Loading