Port PR 34711 changes from corefx #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
approved these changes
Sep 30, 2019
|
LGTM |
cheenamalhotra
approved these changes
Sep 30, 2019
yukiwongky
pushed a commit
to yukiwongky/SqlClient
that referenced
this pull request
Nov 5, 2019
edwardneal
added a commit
to edwardneal/SqlClient
that referenced
this pull request
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/6134
Fixes https://github.com/dotnet/corefx/issues/5450
Tiny code changes, one to ensure that statistics are handled using try-finally blocks and another to make sure that an AutoResetEvent is cleaned up when the parser instance is disconnected. Auto and manual tests pass.