Skip to content

Fix | Check Connected property of sockets during parallel connect #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix | Check Connected property of sockets during parallel connect #2877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0059548
Check Connected property of sockets during parallel connect
David-Engel Sep 20, 2024
138a799
Update src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlCli…
David-Engel Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,8 @@ private static async void ParallelConnectHelper(
{
// Try to connect. If we're successful, store this task into the result task.
await connectTask.ConfigureAwait(false);
success = tcs.TrySetResult(socket);
// A connection attempt could return quickly if a server refuses connection or there is some other error
success = socket.Connected && tcs.TrySetResult(socket);
if (success)
{
// Whichever connection completes the return task is responsible for disposing
Expand Down
Loading