Fix synonym count issues on debug #3098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmedynski
approved these changes
Jan 8, 2025
apoorvdeshmukh
approved these changes
Jan 8, 2025
cheenamalhotra
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
==========================================
- Coverage 72.76% 72.76% -0.01%
==========================================
Files 283 283
Lines 58968 58996 +28
==========================================
+ Hits 42908 42926 +18
- Misses 16060 16070 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jul 25, 2025
Open
This was referenced Sep 1, 2025
Merged
This was referenced Sep 8, 2025
Open
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3016 due to deprecated keywords count mismatch..
This change is more effective for unit testing than #3088, hence proposing the same.
The deprecated keywords weren't tracked before, and this PR removes the counter. If keywords are needed to be deprecated, we can deprecate them on docs and follow deprecation path in future releases. We need not manage counters to be modified as they are very sensitive to changes and affect unit testing in debug mode.