Skip to content

Merge | SqlCommand (Part 1) #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 24, 2025
Merged

Merge | SqlCommand (Part 1) #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d78c53c
Aligning CallerMemberName arguments
benrr101 Jun 27, 2025
73dd08a
Sync TriggerInternalEndAndRetryIfNecessary signatures (as part of syn…
benrr101 Jul 11, 2025
904bb06
Sync attribute formatting and some low stakes stylistic/typo stuff
benrr101 Jul 2, 2025
8b97a46
Move ExecuteReader methods to align with netcore implementation
benrr101 Jul 11, 2025
6fccc8f
Remove SqlCommand from TriggerInternalEndAndRetryIfNecessary function…
benrr101 Jul 11, 2025
75765ed
Round one of syncing method signatures
benrr101 Jul 2, 2025
64244b2
Align keysToBeSentToEnclave, requiresEnclaveComputations, ShouldCache…
benrr101 Jul 2, 2025
780cf6c
Align CancelIgnoreFailureCallback and CancelIgnoreFailure
benrr101 Jul 2, 2025
29dd1ff
Remove unsed CompletePendingReadWith* Methods
benrr101 Jul 2, 2025
ee0660b
Align Write*ExecuteEvent methods
benrr101 Jul 2, 2025
61a5e28
Align Clone, ICloneable.Clone and NotifyDependency
benrr101 Jul 2, 2025
1d4a266
Align BeginExecuteReader and ExecuteReader methods as per netcore imp…
benrr101 Jul 11, 2025
2c0b6b6
Align InternalExecuteNonQueryWithRetryAsync
benrr101 Jul 2, 2025
0b85116
Align ExecuteReaderAsync methods
benrr101 Jul 2, 2025
e78f841
Align ExecuteXmlReaderAsync methods
benrr101 Jul 2, 2025
8f4252b
Sync some more things, like spaces, comments
benrr101 Jul 14, 2025
8bce702
sync _prepareHandle
benrr101 Jul 14, 2025
b3cd36d
Rename CachedAsyncState to AsyncState to allow for CachedAsyncState p…
benrr101 Jul 14, 2025
fdbe141
sync isRetry and isAsync variable names
benrr101 Jul 14, 2025
3ae6f88
Sync { // lines
benrr101 Jul 14, 2025
1aca93c
Sync event/trace/correlation messages
benrr101 Jul 14, 2025
c5920a9
Revert "Remove SqlCommand from TriggerInternalEndAndRetryIfNecessary …
benrr101 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading