Skip to content

Conversation

paulmedynski
Copy link
Contributor

Description

- Backported part of #3494 and all of #3591:
  - Added configurable test jobs timeout, defaulting to 90 minutes.
  - Reduced generated database names to 96 chars to try to fix macOS test failures.
@Copilot Copilot AI review requested due to automatic review settings September 3, 2025 09:49
@paulmedynski paulmedynski requested a review from a team as a code owner September 3, 2025 09:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports fixes from version 6.1 to address macOS test failures by reducing database name length limits and adding configurable test timeouts. The changes focus on improving test reliability across different platforms.

  • Reduced maximum database name length from 128 to 96 characters to fix macOS compatibility
  • Added configurable test job timeouts with a default of 90 minutes to prevent premature test termination

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
DataTestUtility.cs Updated database name generation to limit names to 96 characters with proper truncation logic
dotnet-sqlclient-signing-pipeline.yml Added testsTimeout parameter with 90-minute default
dotnet-sqlclient-ci-project-reference-pipeline.yml Added testsTimeout parameter and passed it to core template
dotnet-sqlclient-ci-package-reference-pipeline.yml Added testsTimeout parameter and passed it to core template
dotnet-sqlclient-ci-core.yml Added testsTimeout parameter and forwarded it to test stage
ci-run-tests-stage.yml Added testsTimeout parameter and passed it to test jobs
run-tests-package-reference-job.yml Added timeout parameter and applied timeoutInMinutes setting
ci-run-tests-job.yml Added timeout parameter and applied timeoutInMinutes setting

@paulmedynski paulmedynski added this to the 6.1.2 milestone Sep 3, 2025
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.69%. Comparing base (7a7b54e) to head (567550b).
⚠️ Report is 10 commits behind head on release/6.1.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/6.1    #3594      +/-   ##
===============================================
- Coverage        69.69%   64.69%   -5.01%     
===============================================
  Files              281      279       -2     
  Lines            62413    61748     -665     
===============================================
- Hits             43500    39948    -3552     
- Misses           18913    21800    +2887     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore 67.09% <ø> (-5.67%) ⬇️
netfx 68.20% <ø> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Sep 3, 2025
@benrr101 benrr101 merged commit 214261f into release/6.1 Sep 3, 2025
128 checks passed
@benrr101 benrr101 deleted the dev/paul/release/6.1/fix-macos branch September 3, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants