[5.2 DRAFT] Stabilize CI Pipelines #3598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmedynski
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR backports critical fixes from previous changes to address macOS test failures by implementing database name length constraints and configurable test timeouts.
- Reduced database name limit from 128 to 96 characters to prevent macOS test failures
- Added configurable timeout parameter for test jobs, defaulting to 90 minutes to handle longer-running tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs | Modified GetUniqueNameForSqlServer to truncate database names to 96 characters maximum |
| eng/pipelines/dotnet-sqlclient-signing-pipeline.yml | Added testsTimeout parameter with 90-minute default |
| eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml | Added timeout parameter and timeoutInMinutes configuration |
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Outdated
Show resolved
Hide resolved
benrr101
previously approved these changes
Sep 3, 2025
- Fixed the unique name generators to: - Keep max lengths to 30 and 96 characters respectively. - Ensure uniqueness at the start of the names. - Added link to database identifier syntax.
- Removing a new test that needs other files that weren't cherry-picked.
- Removed DateOnly tests since that type doesn't exist in 5.2.
…3542) - Adjusted CodeQL suppression to meet the strict requirements of where it may appear relative to the flagged code. - Adding catch for macOS socket error to log and ignore.
Add parameter to sp_help
- Fixed 'async void' tests.
- Upgraded System.Text.Json 6.0.0 to 6.0.11 in the tests to avoid vulnerability warnings.
- Added back test removed in error from cherry-pick. - Removed unnecessary xUnit parallel test class configuration.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmedynski
changed the title
paulmedynski
changed the title
|
Converted this back to a Draft since there is no immediate pressure to get these CI pipelines passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description