FIX | Removing BinaryFormatter from NetFx #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlExceptionTest.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
requested review from
johnnypham,
karinazhou and
DavoudEshtehari
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
…ove-BinaryFormatter
karinazhou
reviewed
Jan 20, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Jan 26, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlExceptionTest.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Jan 26, 2021
johnnypham
reviewed
Feb 16, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Feb 16, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
Outdated
Show resolved
Hide resolved
johnnypham
approved these changes
Feb 18, 2021
karinazhou
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryFormatter is not secure. During testing for net5 and some other tests we noticed it has only been used in
.NETFrameworkinsideSqlDependencyand there was no track of it inside NetCore.According to MS Documentation we had couple of alternative options. XMLSerializer can only work on public methods.
DataContractSerializer is chosen as it can work on private and public members.