Skip to content

FIX | Throwing exception from Dispose should not happen #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

FIX | Throwing exception from Dispose should not happen #920

merged 3 commits into from
Feb 23, 2021

Conversation

JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Feb 18, 2021 •
edited
Loading

Addressing Issue #672, throwing exception from Dispose should not happen.
TryCloseInternal passes an unhandled exception to Close function and the exception comes up from Dispose method. Adding the try/catch block will fix the issue.

@cheenamalhotra cheenamalhotra added this to the 3.0.0-preview1 milestone Feb 19, 2021
@cheenamalhotra cheenamalhotra linked an issue Feb 19, 2021 that may be closed by this pull request
SqlDataReader.DisposeAsync throw SqlException Execution: Timeout Expired. The timeout period elapsed prior to completion of the operation or the server is not responding #672
Closed
@JRahnama JRahnama merged commit cdf423f into dotnet:master Feb 23, 2021
@luarvic luarvic mentioned this pull request Apr 8, 2021
Closed
@JRahnama JRahnama deleted the issue-672 branch July 6, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@David-Engel David-Engel David-Engel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0-preview1

3 participants

@JRahnama @cheenamalhotra @David-Engel