Skip to content

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@JRahnama
Copy link
Contributor

JRahnama commented Apr 7, 2021

LGTM, except a couple of non-blocking minor suggestions and a question.

Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the SQL Server instance is the correct term. If you agreed, update all the combinations, please.

…g-updates

# Conflicts:
#	src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.Designer.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Resources/Strings.resx
@cheenamalhotra cheenamalhotra merged commit ca4957c into dotnet:main May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants