Less assembly logging #4720
Merged
Less assembly logging #4720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
May 26, 2020
|
Here's a corresponding GitHub issue I just moved over from Xamarin.Forms (thanks to a user comment on the developer community issue). This can be added to the fixes list in the commit message on this PR: #4727. |
Fixes: dotnet#4727 Context: https://developercommunity.visualstudio.com/content/problem/1021788/javainterop-assembly-not-found-for-xamarin-android.html Turn some warnings about typemap not finding entries to info-level messages, not visible by default.
grendello
force-pushed
the
less-assembly-logging
branch
from
e2a4fb8 to
2820f3b
Compare
|
Draft release notes Here's what I'll plan to include for this PR in the release notes: To suggest any changes, feel free to reply on this PR. Thanks! |
jonpryor
pushed a commit
that referenced
this pull request
May 27, 2020
Fixes: #4727 Context: https://developercommunity.visualstudio.com/content/problem/1021788/javainterop-assembly-not-found-for-xamarin-android.html Turn some warnings about about typemap not finding entries to info- level messages, not visible by default. Additionally, use `LOG_ASSEMBLY` and `LOG_DEFAULT` for the remaining `log_warn()` calls, as they're assembly-related, not "catch-all".
jonpryor
pushed a commit
that referenced
this pull request
May 28, 2020
Fixes: #4727 Context: https://developercommunity.visualstudio.com/content/problem/1021788/javainterop-assembly-not-found-for-xamarin-android.html Turn some warnings about about typemap not finding entries to info- level messages, not visible by default. Additionally, use `LOG_ASSEMBLY` and `LOG_DEFAULT` for the remaining `log_warn()` calls, as they're assembly-related, not "catch-all".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4727
Context: https://developercommunity.visualstudio.com/content/problem/1021788/javainterop-assembly-not-found-for-xamarin-android.html
Turn some warnings about typemap not finding entries to info-level
messages, not visible by default.