[.editorconfig] Do not trim trailing spaces in .resx files #4954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Context: #4614 (comment) |
jonathanpeppers
approved these changes
Jul 23, 2020
dellis1972
approved these changes
Jul 23, 2020
For contributors using Visual Studio Code with the EditorConfig extension, manual edits to `.resx` files would cause trailing spaces to be trimmed from all lines of the files on each file save. This conflicted with edits made using the Visual Studio `.resx` resource editor because in that editor, each file save creates a new file that includes trailing spaces in the explanatory `Microsoft ResX Schema` XML comment. Adjust the `.editorconfig` file to disable automatic trimming of trailing spaces from `.resx` files. Contributors will now need to trim trailing spaces by hand for any changed lines and avoid changing trailing spaces for any other lines.
brendanzagaeski
force-pushed
the
resx-no-trim
branch
from
51e83ab to
030d224
Compare
|
Changes in the latest force-push: Correct a typo in the commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For contributors using Visual Studio Code with the EditorConfig
extension, manual edits to
.resxfiles would cause trailing spaces tobe trimmed from all lines of the files on each file save. This
conflicted with edits made using the Visual Studio
.resxresourceeditor because in that editor, each file save creates a new file that
includes trailing spaces in the explanatory
Microsoft ResX SchemaXMLcomment.
Adjust the
.editorconfigfile to disable automatic trimming oftrailing spaces from
.resxfiles. Contributors will now need to trimtrailing spaces by hand for any changed lines and avoid changing
trailing spaces for any other lines.