-
Notifications
You must be signed in to change notification settings - Fork 549
[One .NET] Initial workload support #5195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9effc6e
Initial workload drop
pjcollins 3399ea5
Update test project SDK import
pjcollins 523f64b
Remove Xamarin.Android.Sdk.Lite
pjcollins d2abf96
Install workloads in CI
pjcollins 746b4cd
Update common properties and tests for new import ordering
pjcollins 67656d5
Apply feedback and fix macOS executable extraction
pjcollins 42f6946
Fix casing typo
pjcollins 936d853
Move capabilities, remove $(TargetPlatformIdentifier) checks
pjcollins 8324592
Rename .props files imported by Microsoft.Android.Sdk.targets
pjcollins c7fbffe
Separate out workload cleanup target
pjcollins 6f1a0e4
Move $(TargetPlatformSupported) to Microsoft.Android.Sdk.SupportedPla…
pjcollins 8ec2c0c
Ensure relevant darwin _and_ linux workload files are executable
pjcollins 9e4e07e
Remove Microsoft.Android.Sdk.DefaultItems.props
jonathanpeppers decc96a
Move @(ProjectCapability) items to their own file
jonathanpeppers 480006d
ExtractWorkloadPacks should <Touch/> all files
jonathanpeppers 420928f
Merge remote-tracking branch 'upstream/master' into workload-playground
jonathanpeppers d26730b
Remove TODO in DotNetPack test
jonathanpeppers 45e811b
Fix for using net5.0-android30.0 in NuGet packages
jonathanpeppers a504378
Temporary fix for _AndroidXShouldRunMigration=false
jonathanpeppers 809ebf5
Rename workload to Microsoft.NET.Workload.Android
pjcollins 052862a
Clean up old workload pack name
pjcollins 545e524
Merge remote-tracking branch 'upstream/master' into workload-playground
pjcollins b2076e0
Fix version miscalculation that can occur in PR builds
pjcollins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
build-tools/create-packs/Microsoft.NET.Workload.Android.proj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
<!-- | ||
*********************************************************************************************** | ||
Microsoft.NET.Workload.Android.proj | ||
|
||
This project file is used to create the Microsoft.NET.Workload.Android NuGet, which is the | ||
workload manifest pack containing information about the various Microsoft.Android workloads. | ||
*********************************************************************************************** | ||
--> | ||
<Project Sdk="Microsoft.Build.NoTargets"> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>netcoreapp3.1</TargetFramework> | ||
<PackageId>Microsoft.NET.Workload.Android</PackageId> | ||
<Authors>Microsoft</Authors> | ||
<Description>Microsoft.Android workload manifest. Please do not reference directly.</Description> | ||
<OutputPath>..\..\bin\Build$(Configuration)\nupkgs\</OutputPath> | ||
</PropertyGroup> | ||
|
||
<Import Project="..\..\Configuration.props" /> | ||
<Import Project="..\..\build-tools\installers\create-installers.targets" /> | ||
|
||
<PropertyGroup> | ||
<BeforePack> | ||
_GenerateXAWorkloadContent; | ||
$(BeforePack); | ||
</BeforePack> | ||
</PropertyGroup> | ||
|
||
<!-- FIXME: Temporarily Generate WorkloadManifest.targets and WorkloadManifest.json files inline while content is trivial. --> | ||
<Target Name="_GenerateXAWorkloadContent" | ||
DependsOnTargets="_GetDefaultPackageVersion" > | ||
<PropertyGroup> | ||
<WorkloadManifestTargetsPath>$(OutputPath)\workload-manifest\WorkloadManifest.targets</WorkloadManifestTargetsPath> | ||
<WorkloadManifestJsonPath>$(OutputPath)\workload-manifest\WorkloadManifest.json</WorkloadManifestJsonPath> | ||
<WorkloadManifestTargetsContent> | ||
<![CDATA[ | ||
<Project> | ||
<Import Project="Sdk.targets" | ||
Sdk="Microsoft.Android.Sdk" | ||
Condition=" '%24(TargetPlatformIdentifier)' == 'Android' " /> | ||
</Project> | ||
]]> | ||
</WorkloadManifestTargetsContent> | ||
<WorkloadManifestJsonContent> | ||
<![CDATA[ | ||
{ | ||
"version": 5, | ||
"workloads": { | ||
"microsoft-android-sdk-full": { | ||
"description": "Android SDK", | ||
"packs": [ | ||
"Microsoft.Android.Sdk", | ||
"Microsoft.Android.Ref", | ||
] | ||
} | ||
}, | ||
"packs": { | ||
"Microsoft.Android.Sdk": { | ||
"kind": "sdk", | ||
"version": "$(AndroidPackVersionLong)" | ||
}, | ||
"Microsoft.Android.Ref": { | ||
"kind": "framework", | ||
"version": "$(AndroidPackVersionLong)" | ||
} | ||
} | ||
} | ||
]]> | ||
</WorkloadManifestJsonContent> | ||
</PropertyGroup> | ||
|
||
<WriteLinesToFile File="$(WorkloadManifestTargetsPath)" | ||
Lines="$(WorkloadManifestTargetsContent)" | ||
Overwrite="true" /> | ||
|
||
<WriteLinesToFile File="$(WorkloadManifestJsonPath)" | ||
Lines="$(WorkloadManifestJsonContent)" | ||
Overwrite="true" /> | ||
|
||
<ItemGroup> | ||
<_PackageFiles Include="$(WorkloadManifestTargetsPath)" PackagePath="\" /> | ||
<_PackageFiles Include="$(WorkloadManifestJsonPath)" PackagePath="\" /> | ||
</ItemGroup> | ||
</Target> | ||
|
||
</Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.