[build] fix for case-sensitive file systems #5381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://docs.microsoft.com/visualstudio/msbuild/customize-your-build?view=vs-2019#customize-the-solution-build @grendello was hitting a problem building Xamarin.Android on Linux, every project would fail saying `PackDotNet` does not exist: $ make pack-dotnet ... java-runtime.csproj : error MSB4057: The target "PackDotNet" does not exist in the project. Reading the docs for `Before.*.sln.targets`: > When MSBuild builds a solution file, it first translates it > internally into a project file and then builds that. The generated > project file imports `before.{solutionname}.sln.targets` before > defining any targets... `before.` is all lowercase... Renaming the file fixed the build on Linux.
grendello
approved these changes
Dec 7, 2020
dellis1972
approved these changes
Dec 8, 2020
grendello
pushed a commit
to grendello/xamarin-android
that referenced
this pull request
Dec 8, 2020
Context: https://docs.microsoft.com/visualstudio/msbuild/customize-your-build?view=vs-2019#customize-the-solution-build @grendello was hitting a problem building Xamarin.Android on Linux, every project would fail saying `PackDotNet` does not exist: $ make pack-dotnet ... java-runtime.csproj : error MSB4057: The target "PackDotNet" does not exist in the project. Reading the docs for `Before.*.sln.targets`: > When MSBuild builds a solution file, it first translates it > internally into a project file and then builds that. The generated > project file imports `before.{solutionname}.sln.targets` before > defining any targets... `before.` is all lowercase. Renaming the file to use `before` and not `Before` fixes the build on Linux.
pjcollins
added a commit
to dotnet/java-interop
that referenced
this pull request
Oct 13, 2021
Context: dotnet/android#5381 Automatic importing of `before*.targets` and `after*.targets` files is case sensitive on Linux, and only lowercase files will work.
pjcollins
added a commit
to dotnet/java-interop
that referenced
this pull request
Oct 13, 2021
Context: dotnet/android#5381 Automatic importing of `before*.targets` and `after*.targets` files is case sensitive on Linux, and only lowercase files will work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://docs.microsoft.com/visualstudio/msbuild/customize-your-build?view=vs-2019#customize-the-solution-build
@grendello was hitting a problem building Xamarin.Android on Linux,
every project would fail saying
PackDotNetdoes not exist:Reading the docs for
Before.*.sln.targets:before.is all lowercase... Renaming the file fixed the build on Linux.