Bump to .NET 6.0.100-preview.3.21161.23 #5733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
changed the title
jonathanpeppers
changed the title
jonathanpeppers
force-pushed
the
dotnet-preview.3.21161.23
branch
2 times, most recently
from
e0bb971 to
ff18333
Compare
Changes: dotnet/installer@1a9103d...19e22a7 At first, Android "Hello World" fails with: > dotnet build -c Release ILLink : error IL1009: Assembly 'System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' reference 'System.Configuration.ConfigurationManager, Version=0.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' could not be resolved Dropping the `--skip-unresolved false` switch passed to ILLink solves this issue. This was a recommendation from Sven Boemer on the .NET team. A nice, side-effect, is we no longer need workarounds like this any longer: <ItemGroup Condition=" '$(Configuration)' == 'Release' "> <PackageReference Include="System.CodeDom" Version="6.0.0-*" /> <PackageReference Include="System.Configuration.ConfigurationManager" Version="6.0.0-*" /> <PackageReference Include="System.Diagnostics.PerformanceCounter" Version="6.0.0-*" /> <PackageReference Include="System.Diagnostics.EventLog" Version="6.0.0-*" /> <PackageReference Include="System.Drawing.Common" Version="6.0.0-*" /> <PackageReference Include="System.IO.Ports" Version="6.0.0-*" /> <PackageReference Include="System.Threading.AccessControl" Version="6.0.0-*" /> </ItemGroup> I removed these from several tests. `BuildReleaseArm64` test, net6 apk size difference before/after Simple XA: -"PackageSize": 2885411 +"PackageSize": 2889606 XF/XA -"PackageSize": 9886918 +"PackageSize": 8746124 The Xamarin.Forms app saw quite a bit of improvement, since we don't have to bring in these `@(PackageReference)` anymore. ~~ Other changes ~~ I updated `PerformanceTest` to ignore `NotSupportedException` due to: System.NotSupportedException : Unsupported log file format. Latest supported version is 10, the log file has version 11. We need to use a new version of this package when it is available: https://www.nuget.org/packages/MSBuild.StructuredLogger/2.1.303
jonathanpeppers
force-pushed
the
dotnet-preview.3.21161.23
branch
from
ff18333 to
0331535
Compare
Hopefully fixes runtime crash in .NET 6 Mono.Android-Tests:
Can't find custom attr constructor image: Mono.Android.dll mtoken: 0x0a000464 due to:
Could not resolve type with token 010000fb from typeref (expected class 'System.Runtime.CompilerServices.InternalsVisibleToAttribute' in assembly 'System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e') assembly:System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e type:System.Runtime.CompilerServices.InternalsVisibleToAttribute member:(null)
jonathanpeppers
commented
Mar 15, 2021
| <linker> | ||
| <assembly fullname="System.Private.CoreLib"> | ||
| <type fullname="System.Globalization.GlobalizationMode" /> | ||
| <type fullname="System.Runtime.CompilerServices.InternalsVisibleToAttribute" /> |
There was a problem hiding this comment.
This fixed a crash in Mono.Android-Tests:
Can't find custom attr constructor image: Mono.Android.dll mtoken: 0x0a000464 due to:
Could not resolve type with token 010000fb from typeref (expected class 'System.Runtime.CompilerServices.InternalsVisibleToAttribute' in assembly 'System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e') assembly:System.Private.CoreLib, Version=6.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e type:System.Runtime.CompilerServices.InternalsVisibleToAttribute member:(null)
jonathanpeppers
commented
Mar 15, 2021
| <!-- Please update DotNetRuntimePacksVersion below accordingly --> | ||
| <DotNetPreviewVersionBand Condition=" '$(DotNetPreviewVersionBand)' == '' ">6.0.100</DotNetPreviewVersionBand> | ||
| <DotNetPreviewVersionFull Condition=" '$(DotNetPreviewVersionFull)' == '' ">$(DotNetPreviewVersionBand)-preview.2.21155.3</DotNetPreviewVersionFull> | ||
| <DotNetPreviewVersionFull Condition=" '$(DotNetPreviewVersionFull)' == '' ">$(DotNetPreviewVersionBand)-preview.3.21161.23</DotNetPreviewVersionFull> |
There was a problem hiding this comment.
FYI @rolfbjarne / @spouliot looks Android was able to bump to this version with just some minor changes.
There was a problem hiding this comment.
Yeah, we have a PR going here: dotnet/macios#10772, I was just waiting for P2 to go out first.
dellis1972
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, Android "Hello World" fails with:
Dropping the
--skip-unresolved falseswitch passed to ILLink solvesthis issue. This was a recommendation from Sven Boemer on the .NET team.
A nice, side-effect, is we no longer need workarounds like this any
longer:
I removed these from several tests.
BuildReleaseArm64test, net6 apk size difference before/afterSimple XA:
XF/XA
The Xamarin.Forms app saw quite a bit of improvement, since we don't
have to bring in these
@(PackageReference)anymore.Other changes
I updated
PerformanceTestto ignoreNotSupportedExceptiondue to:We need to use a new version of this package when it is available:
https://www.nuget.org/packages/MSBuild.StructuredLogger/2.1.303