Bump to dotnet/installer/release/6.0.1xx-preview7@456900d 6.0.100-preview.7.21372.19 #6112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…210721.2 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.7.21369.5 -> To Version 6.0.100-preview.7.21371.2 Dependency coherency updates Microsoft.NETCore.App.Ref From Version 6.0.0-preview.7.21368.2 -> To Version 6.0.0-preview.7.21370.18 (parent: Microsoft.Dotnet.Sdk.Internal
dotnet-maestro
bot
requested review from
jonathanpeppers,
jonpryor and
pjcollins
as code owners
There was a problem hiding this comment.
Hmm, yeah this is busted. Looks like you can't install "abstract" workloads anymore:
Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag"
stderr | Workload with id microsoft-net-runtime-android is not recognized.
…210721.16 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.7.21369.5 -> To Version 6.0.100-preview.7.21371.16 Dependency coherency updates Microsoft.NETCore.App.Ref From Version 6.0.0-preview.7.21368.2 -> To Version 6.0.0-preview.7.21370.18 (parent: Microsoft.Dotnet.Sdk.Internal
|
@jonathanpeppers : why's it trying to install the |
@jonpryor we install that workload by itself so we can build against the header files it contains: It turns out, it was a bug that we were able to install I know what to do here to fix it. I think we can go back to using the |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 22, 2021
Context: dotnet#6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that we were even able to install this workload in the first place! The concept behind "abstract" workloads is they are not user visible in any way. They're meant to be an implementation detail. In 0150bbb, I setup `xaprepare` to install `microsoft-net-runtime-android`, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so the version matches `$(DotNetRuntimePacksVersion)`. `microsoft-net-runtime-android` will get installed later during the `ExtractWorkloadPacks` target: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that we were even able to install this workload in the first place! The concept behind "abstract" workloads is they are not user visible in any way. They're meant to be an implementation detail. In 0150bbb, I setup `xaprepare` to install `microsoft-net-runtime-android`, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so the version matches `$(DotNetRuntimePacksVersion)`. `microsoft-net-runtime-android` will get installed later during the `ExtractWorkloadPacks` target: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonpryor
pushed a commit
that referenced
this pull request
Jul 22, 2021
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonpryor
pushed a commit
that referenced
this pull request
Jul 22, 2021
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
…view7-ff84318d-a321-4876-af8f-b24f537c5e6e
…210722.19 Microsoft.Dotnet.Sdk.Internal From Version 6.0.100-preview.7.21369.5 -> To Version 6.0.100-preview.7.21372.19 Dependency coherency updates Microsoft.NETCore.App.Ref From Version 6.0.0-preview.7.21368.2 -> To Version 6.0.0-preview.7.21371.11 (parent: Microsoft.Dotnet.Sdk.Internal
Clean doesn't actually delete directories, no need to test for this.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 23, 2021
Context: dotnet#6112 The .NET 6 Preview 7 bump had a test failure: CleanBasicBindingLibrary("class-parse") obj/Release should have no directories. Expected: <empty> But was: < "/Users/runner/work/1/s/bin/TestRelease/temp/CleanBasicBindingLibraryclass-parse/obj/Release/refint" > `refint` is a new directory, see: * dotnet/sdk@e424c0e * https://github.com/dotnet/msbuild/blob/9e576281e638d60701ca34411e2483bed01e35c7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L397 Clean doesn't actually delete directories, no need to test for this. The test already is checking if any files exist, and that should be sufficient.
jonathanpeppers
added a commit
that referenced
this pull request
Jul 23, 2021
Context: #6112 The .NET 6 Preview 7 bump had a test failure: CleanBasicBindingLibrary("class-parse") obj/Release should have no directories. Expected: <empty> But was: < "/Users/runner/work/1/s/bin/TestRelease/temp/CleanBasicBindingLibraryclass-parse/obj/Release/refint" > `refint` is a new directory, see: * dotnet/sdk@e424c0e * https://github.com/dotnet/msbuild/blob/9e576281e638d60701ca34411e2483bed01e35c7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L397 Clean doesn't actually delete directories, no need to test for this. The test already is checking if any files exist, and that should be sufficient.
jonathanpeppers
added a commit
that referenced
this pull request
Jul 23, 2021
Context: #6112 The .NET 6 Preview 7 bump had a test failure: CleanBasicBindingLibrary("class-parse") obj/Release should have no directories. Expected: <empty> But was: < "/Users/runner/work/1/s/bin/TestRelease/temp/CleanBasicBindingLibraryclass-parse/obj/Release/refint" > `refint` is a new directory, see: * dotnet/sdk@e424c0e * https://github.com/dotnet/msbuild/blob/9e576281e638d60701ca34411e2483bed01e35c7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L397 Clean doesn't actually delete directories, no need to test for this. The test already is checking if any files exist, and that should be sufficient.
jonathanpeppers
approved these changes
Jul 23, 2021
jonathanpeppers
changed the title
jonathanpeppers
deleted the
darc-release/6.0.1xx-preview7-ff84318d-a321-4876-af8f-b24f537c5e6e
branch
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
…net#6114) Context: dotnet#6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
) Context: dotnet#6112 The .NET 6 Preview 7 bump had a test failure: CleanBasicBindingLibrary("class-parse") obj/Release should have no directories. Expected: <empty> But was: < "/Users/runner/work/1/s/bin/TestRelease/temp/CleanBasicBindingLibraryclass-parse/obj/Release/refint" > `refint` is a new directory, see: * dotnet/sdk@e424c0e * https://github.com/dotnet/msbuild/blob/9e576281e638d60701ca34411e2483bed01e35c7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L397 Clean doesn't actually delete directories, no need to test for this. The test already is checking if any files exist, and that should be sufficient.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Context: #6112 (review) The .NET Preview 7 bump is failing with: Running: /Users/builder/Library/Android/dotnet/dotnet "workload" "install" "microsoft-net-runtime-android" "--skip-manifest-update" "--verbosity" "diag" stderr | Workload with id microsoft-net-runtime-android is not recognized. However, it was a bug in the `dotnet workload install` command that allowed us to even install this workload in the first place! The concept concept behind "abstract" workloads is they are not user visible in any way; they're meant to be an implementation detail. In commit 0150bbb, I setup `xaprepare` to install the `microsoft-net-runtime-android` workload, but we don't actually even need to do this. We can simply update the `sdk-manifest` for this pack, so that the version matches `$(DotNetRuntimePacksVersion)`. The `microsoft-net-runtime-android` workload will get installed later during the `ExtractWorkloadPacks` target, as part of installing the `android` or `android-aot` workloads: https://github.com/xamarin/xamarin-android/blob/c1a2ee70214e86757541b5759c9ed54941bd4680/build-tools/create-packs/Directory.Build.targets#L119-L122 Since `android` and `android-aot` extend `microsoft-net-runtime-android`, this step will install it.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Context: #6112 The .NET 6 Preview 7 bump had a test failure: CleanBasicBindingLibrary("class-parse") obj/Release should have no directories. Expected: <empty> But was: < "/Users/runner/work/1/s/bin/TestRelease/temp/CleanBasicBindingLibraryclass-parse/obj/Release/refint" > `refint` is a new directory, see: * dotnet/sdk@e424c0e * https://github.com/dotnet/msbuild/blob/9e576281e638d60701ca34411e2483bed01e35c7/src/Tasks/Microsoft.Common.CurrentVersion.targets#L397 Clean doesn't actually delete directories, no need to test for this. The test already is checking if any files exist, and that should be sufficient.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/installer