Skip to content

Conversation

jonathanpeppers
Copy link
Member

Some of our PerformanceTest's are currently ignored due to:

Ignored : Xamarin.Android.Build.Tests.PerformanceTest.Build_No_Changes
Test requires an updated MSBuild.StructuredLogger

We ignored these tests in 304e698. This was failing due to changes in
the .binlog file format.

I think we can remove this with the latest MSBuild.StructuredLogger.

Some of our `PerformanceTest`'s are currently ignored due to:

    Ignored : Xamarin.Android.Build.Tests.PerformanceTest.Build_No_Changes
    Test requires an updated MSBuild.StructuredLogger

We ignored these tests in 304e698. This was failing due to changes in
the `.binlog` file format.

I think we can remove this with the latest MSBuild.StructuredLogger.
@jonathanpeppers
Copy link
Member Author

These tests are running and passing now:

image

@jonathanpeppers
Copy link
Member Author

I think we can ignore the test timeout here (shouldn't be affected by this PR), going to merge.

@jonathanpeppers jonathanpeppers merged commit 9af3732 into dotnet:main Aug 5, 2021
@jonathanpeppers jonathanpeppers deleted the msbuild.structuredlogger.2.1.500 branch August 5, 2021 22:15
jonpryor pushed a commit to jonpryor/xamarin-android that referenced this pull request Aug 25, 2021
Some of our `PerformanceTest`'s are currently ignored due to:

    Ignored : Xamarin.Android.Build.Tests.PerformanceTest.Build_No_Changes
    Test requires an updated MSBuild.StructuredLogger

We ignored these tests in 304e698. This was failing due to changes in
the `.binlog` file format.

I think we can remove this with the latest MSBuild.StructuredLogger.
jonpryor pushed a commit that referenced this pull request Aug 26, 2021
Some of our `PerformanceTest`'s are currently ignored due to:

    Ignored : Xamarin.Android.Build.Tests.PerformanceTest.Build_No_Changes
    Test requires an updated MSBuild.StructuredLogger

We ignored these tests in 304e698. This was failing due to changes in
the `.binlog` file format.

I think we can remove this with the latest MSBuild.StructuredLogger.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants