Bump to lipzip/rel-1-3-0/51ff59da (#863) #874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version fixes CVE-2017-12858 and CVE-2017-14107.
grendello
added
full-mono-integration-build
|
build |
Closed
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Sep 19, 2017
When bumping libzip in dotnet#874 or dotnet#863 libzip is no longer building under mxe. We can switch to using the NuGet packages instead. Also switched to using `<Content />` to link in the files, which works better if `<ProjectReference />` is used with `libzip-windows.mdproj`.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Sep 19, 2017
When bumping libzip in dotnet#874 or dotnet#863 libzip is no longer building under mxe. We can switch to using the NuGet packages instead.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 26, 2021
Changes: http://github.com/xamarin/Java.Interop/compare/ff2714200107fb616828b9d1013f69605791d2ba...b7982e423952a4c4afe0c33f36ac80eed7fa57a2 * dotnet/java-interop@b7982e42: Revert "[build] Use GitInfo to generate $(Version) (dotnet#865)" (dotnet#874) * dotnet/java-interop@9a878f21: [build] Properly implement "parent directory.override.props" (dotnet#300) (dotnet#873) * dotnet/java-interop@0c5d454c: [Java.Interop] fix .NET 6 linker warnings (dotnet#870) * dotnet/java-interop@8898bc14: [build] Import $(MSBuildProjectDirectory).override.props (dotnet#872) * dotnet/java-interop@d16b1e56: [build] Use GitInfo to generate $(Version) (dotnet#865) * dotnet/java-interop@2eb9ff26: [build] .NET 6 P7 Support (dotnet#869) Set `$(XamarinAndroidToolsDirectory)` for `external/Java.Interop` so that the Java.Interop build uses `external/xamarin-android-tools`.
jonpryor
added a commit
that referenced
this pull request
Aug 26, 2021
Changes: http://github.com/xamarin/Java.Interop/compare/ff2714200107fb616828b9d1013f69605791d2ba...b7982e423952a4c4afe0c33f36ac80eed7fa57a2 * dotnet/java-interop@b7982e42: Revert "[build] Use GitInfo to generate $(Version) (#865)" (#874) * dotnet/java-interop@9a878f21: [build] Properly implement "parent directory.override.props" (#300) (#873) * dotnet/java-interop@0c5d454c: [Java.Interop] fix .NET 6 linker warnings (#870) * dotnet/java-interop@8898bc14: [build] Import $(MSBuildProjectDirectory).override.props (#872) * dotnet/java-interop@d16b1e56: [build] Use GitInfo to generate $(Version) (#865) * dotnet/java-interop@2eb9ff26: [build] .NET 6 P7 Support (#869) Set `$(XamarinAndroidToolsDirectory)` for `external/Java.Interop` so that the Java.Interop build uses `external/xamarin-android-tools`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version fixes CVE-2017-12858 and CVE-2017-14107.
PR notes
The original PR failed to build on Windows, its follow up failed as well - despite passing the correct (or so it seemed)
CMakeflags, static library was still being built. This, hopefully, fixes the issue.