[windows] fix for $(HOME) blank in some situations
#879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the build under a VSTS build agent, `$(HOME)` was evaluated to an empty string. `$(USERPROFILE)` seems to be a more reliable way to retrieve the correct path on Windows. Example here: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1004861
|
@jonathanpeppers, |
jonpryor
pushed a commit
that referenced
this pull request
Sep 16, 2021
Fixes: #6271 Context: 2d81740 Context: #5749 Context: dotnet/java-interop@d16b1e5 Changes: dotnet/java-interop@f359e73...8f7ddcd * dotnet/java-interop@8f7ddcdd: [build] Fix 'BuildVersionInfo_g_cs' build target. (#881) * dotnet/java-interop@7068f4b2: [build] Enable string operations globalization code analyzers. (#879) * dotnet/java-interop@3e6a6232: [build] Use GitInfo to Generate Version information. (#875) In order to better support building solutions which reference both .NET 6 and legacy projects within Visual Studio, we have begun strong-naming all the MSBuild-related assemblies; see also 2d81740. This allows loading two different version of the "same" assembly, e.g. `Java.Interop.Tools.Diagnostics.dll`, from two different filesystem locations in the same AppDomain/AssemblyLoadContext. However, strong-naming is only part of the solution. The other part is that, for sanity and reliability, the "two different versions of the 'same' assembly" should *also* have different assembly *versions*. If they have the same assembly version, are they truly different? Multiple sub-modules have been updated to use the [`GitInfo`][0] [NuGet Package][1] so that assembly versions are unique per-commit: * `external/xamarin-android-tools`: 25c5cb5 * `.external` & `monodroid`: 2d81740 Update the `external/Java.Interop` submodule to follow suit. This in turn requires updates to `xaprepare` and the CI YAML files to ensure that `GitInfo` is configured correctly within Java.Interop. [0]: https://github.com/devlooped/GitInfo [1]: https://www.nuget.org/packages/GitInfo/2.1.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the build under a VSTS build agent,
$(HOME)was evaluatedto an empty string.
$(USERPROFILE)seems to be a more reliable way toretrieve the correct path on Windows.
Example here:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1004861