[tests] Windows fixes for Xamarin.Android.Build.Tests #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves several issues: - `XamarinProject` was not finding NuGet.exe on Windows and the process is visible - On Windows, the tests need `libzip.dll` and `zlib.dll` in their output - `BindingBuildTest` was not using `android-support-multidex.jar` from VS 2017 installation - `RunAdbCommand` was using unix-style paths Changes: - Run `.nuget/NuGet.exe` on Windows and make it hidden - Bump LibZipSharp, which better supports `<ProjectReference />`, `libzip-windows.mdproj` no longer needs to do anything on Windows - `BindingBuildTest` can use the `FrameworkLibDirectory` property - `RunAdbCommand` should use `Path.Combine` - Removed duplicate `FSharp.Compiler.CodeDom` in `packages.config`
|
@jonathanpeppers, |
dellis1972
approved these changes
Sep 22, 2017
jonpryor
pushed a commit
that referenced
this pull request
Oct 15, 2021
Context: dotnet/java-interop@846f211 Changes: dotnet/java-interop@c936d09...7c8d463 * dotnet/java-interop@7c8d4638: [build] Fix -t:Prepare on Linux (#892) * dotnet/java-interop@41ba3485: [tests] Add net6.0 TargetFramework. (#888) * dotnet/java-interop@403dd37a: [class-parse] Ignore .jnilib files within .jar files (#890) * dotnet/java-interop@bda6be43: [class-parse] Add support for some JDK-11 constant pool types (#889) * dotnet/java-interop@4277ac96: Bump to xamarin/xamarin-android-tools/main@34e98e2b (#887) * dotnet/java-interop@846f2116: [generator] Remove buggy annotation loose match (#886) Commit dotnet/java-interop@846f2116 made our annotation support more accurate, which had a side-effect of introducing changes to generated custom attributes. Update `tests/api-compatibility/acceptable-breakages*.txt` to deal with the fallout from dotnet/java-interop@846f2116.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves several issues:
XamarinProjectwas not finding NuGet.exe on Windows and the processis visible
libzip.dllandzlib.dllin their outputBindingBuildTestwas not usingandroid-support-multidex.jarfromVS 2017 installation
RunAdbCommandwas using unix-style pathsChanges:
.nuget/NuGet.exeon Windows and make it hidden<ProjectReference />,libzip-windows.mdprojno longer needs to do anything on WindowsBindingBuildTestcan use theFrameworkLibDirectorypropertyRunAdbCommandshould usePath.CombineFSharp.Compiler.CodeDominpackages.config(test runner warning)