[Xamarin.Android.Build.Tasks] Create classes.zip for dx.jar. [WIP] #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atsushieno this should fix your |
|
build |
dellis1972
changed the title
|
Watch |
jonpryor
reviewed
Oct 4, 2017
| cmd.AppendFileNameIfNotNull (ClassesOutputDirectory); | ||
| var zip = Path.GetFullPath (Path.Combine (ClassesOutputDirectory, "classes.zip")); | ||
| if (!File.Exists (zip)) { | ||
| Log.LogError ($"'{zip}' does not exist. Please rebuild the project."); |
There was a problem hiding this comment.
LogError() doesn't throw an exception, so execution will continue after this point. Should an exception be thrown + caught in Execute() instead?
Commit 2d23a27 reverted a change which is required for j8.jar. But the change resulted in a command line which would exceed the max command line limits on windows. It turns out that both dx.jar and j8.jar allow for a `zip` file to be used to pass in the `.class` files. So lets create a zip and refresh/update it on each build. Then use that rather than the class directory in `CompileToDalvik`. This also fixes the JarContentBuilder to pick up the android sdk and ndk directories from the environment variables which the build system pass in.
dellis1972
added a commit
that referenced
this pull request
Oct 6, 2017
Commit 2d23a27 reverted a change which is required for `j8.jar`. But the change resulted in a command line which would exceed the max command line limits on windows. It turns out that both `dx.jar` and `j8.jar` allow for a `zip` file to be used to pass in the `.class` files. So lets create a zip and refresh/update it on each build. Then use that rather than the class directory in `<CompileToDalvik/>`. This also fixes `JarContentBuilder` to pick up the android sdk and ndk directories from the environment variables which the build system pass in.
jonpryor
pushed a commit
that referenced
this pull request
Nov 12, 2021
Changes: dotnet/java-interop@dcdcce1...087684a * dotnet/java-interop@087684a7: [generator] Improve Javadoc remarks on properties (#911) A `frameworks.xml` file will now be passed to `mdoc.exe` when updating external API docs. This file contains the metadata required to find and update or create [`FrameworksIndex` files][0]. The version of `Mono.Android.dll` used to generate docs will no longer be passed to `mdoc.exe`. Instead, it will be copied to the relative `%(Source)` directory described in `frameworks.xml`, to be resolved automatically. The `mdoc` package version specification has also been fixed, and we'll now use [`5.8.5`][1] instead of `5.0.0.25` (`%(PackageReference.PackageVersion)` is not A Thing; `%(Version)` should be used, but wasn't). [0]: https://github.com/xamarin/android-api-docs/tree/cd414a93057b6f61afcdd3db6ff44391fb166246/docs/Mono.Android/en/FrameworksIndex [1]: https://www.nuget.org/packages/mdoc/5.8.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2d23a27 reverted a change which is required for j8.jar.
But the change resulted in a command line which would exceed
the max command line limits on windows.
It turns out that both dx.jar and j8.jar allow for a
zipfileto be used to pass in the
.classfiles. So lets create a zipand refresh/update it on each build. Then use that rather than
the class directory in
CompileToDalvik.This also fixes the JarContentBuilder to pick up the android
sdk and ndk directories from the environment variables which
the build system pass in.