Add ML.NET notes from session 5 #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauheen
reviewed
Nov 30, 2018
|
|
||
| var reader = mlContext.Data.CreateTextFileSource(options); | ||
| ``` | ||
| - Tom check what you were plan on checking :-) No newline at end of file |
TomFinley
reviewed
Nov 30, 2018
| - Solves two problems: the chaining for `IHostEnvironment` and the | ||
| discoverability for finding implementations of common abstraction. | ||
| - They are solved by offering extension methods | ||
| - We should align the naming of `XxxCatalog` with `XxxContext` |
TomFinley
reviewed
Nov 30, 2018
|
|
||
| var reader = mlContext.Data.CreateTextFileSource(options); | ||
| ``` | ||
| - Tom check what you were plan on checking :-) No newline at end of file |
There was a problem hiding this comment.
It turns out the answer was, "we did both." 😛 Issue here.
TomFinley
reviewed
Nov 30, 2018
| `CreateTextReader()` | ||
| - We should have a pattern for the arguments: | ||
| - Simple set of arguments should just be parameters | ||
| - More complicated arguments should be an option class that is mutable |
There was a problem hiding this comment.
Entered as this issue, this was a fairly lengthy discussion that went into more things than are captured in this paragraph so it's possible I forgot something in the issue, let me know if so.
TomFinley
reviewed
Dec 1, 2018
| - Most of the methods aren't verbs; instead of `TextReader()` it should be | ||
| `CreateTextReader()` | ||
| - We should have a pattern for the arguments: | ||
| - Simple set of arguments should just be parameters |
There was a problem hiding this comment.
This is captured in existing issues but to reinforce also mentioned it as a subitem in a new issue as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.