Skip to content

Set copyright and package license #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 21, 2019

Prepares repo for change dotnet/arcade#2003 by setting Copyright and PackageLicenseExpression properties. These values will be required to be set by each repository once dotnet/arcade#2003 is merged.

In order to not break the current builds this change sets the properties conditionally. This condition can be removed once all repos switch to Arcade that has dotnet/arcade#2003.

@markwilkie

@jcagme
Copy link
Contributor

jcagme commented Feb 21, 2019

These values will be required to be set by each repository once dotnet/arcade#2003 is merged.

What happens if:

If merging this PR will break builds until dotnet/arcade#2003 gets merged the arcade dependency flow will be broken

@tmat
Copy link
Member Author

tmat commented Feb 21, 2019

No, merging this PR has no effect on the current build. It kicks in only after dotnet/arcade#2003 is merged

@jcagme
Copy link
Contributor

jcagme commented Feb 22, 2019

So we need all the repos to make the same change before dotnet/arcade#2003 is merged?

@tmat
Copy link
Member Author

tmat commented Feb 22, 2019

Yes, I already sent 50+ PRs :)

@markwilkie
Copy link
Member

Yea, I think we should have @tmat do all of our wide ranging arcade changes from now on! :)

@tmat
Copy link
Member Author

tmat commented Feb 22, 2019

@jcagme OK to merge?

@tmat
Copy link
Member Author

tmat commented Feb 22, 2019

@jcagme Hmm... I do not have merge permissions :(

@tmat
Copy link
Member Author

tmat commented Feb 24, 2019

@jcagme Could you please merge or give me permissions to do so?

@jcagme jcagme merged commit aca0073 into dotnet:master Feb 25, 2019
@jcagme
Copy link
Contributor

jcagme commented Feb 25, 2019

@tmat now it is merged. Looks like I cannot give you permissions from mobile so once in my box I’ll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants