Test reporter logging is owned by root if first work item is docker work item #9208
Description
It seems in the scenario where the first work item a machine ever runs is in a docker scenario and uses the reporter, that machine will not be able to appened to the runner logs, as noted below:
bad machine: run.py (reporter log) is owned by root:
helixbot@a00C88M:~/dotnetbuild/logs$ ls -al
total 14048
drwxrwxrwx 2 helixbot root 4096 Apr 27 22:32 .
drwxr-xr-x 4 root root 4096 Apr 27 18:14 ..
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:20 client_0_last_started
-rw-r--r-- 1 helixbot helixbot 6415 Apr 27 18:14 installer.log
-rw-r--r-- 1 root root 0 Apr 27 18:17 run.py.err
-rw-r--r-- 1 root root 2951 Apr 27 21:43 run.py.log
-rw-r--r-- 1 helixbot helixbot 6377 Apr 27 21:43 run_client.py.err
-rw-r--r-- 1 helixbot helixbot 14279979 Apr 27 22:55 run_client.py.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 18:14 run_heartbeat.py.err
-rw-r--r-- 1 helixbot helixbot 61350 Apr 27 22:55 run_heartbeat.py.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 18:14 start_helix.py.err
-rw-r--r-- 1 helixbot helixbot 194 Apr 27 18:14 start_helix.py.log
Good machine: run.py (reporter log) is owned by helixbot:
helixbot@a00C8C3:~/dotnetbuild/logs$ ls -al
total 2244
drwxrwxrwx 2 helixbot root 4096 Apr 27 22:57 .
drwxr-xr-x 4 root root 4096 Apr 27 22:47 ..
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:56 client_0_last_started
-rw-r--r-- 1 helixbot helixbot 6415 Apr 27 22:47 installer.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:48 run.py.err
-rw-r--r-- 1 helixbot helixbot 8019 Apr 27 22:57 run.py.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:47 run_client.py.err
-rw-r--r-- 1 helixbot helixbot 2261292 Apr 27 22:57 run_client.py.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:47 run_heartbeat.py.err
-rw-r--r-- 1 helixbot helixbot 2390 Apr 27 22:57 run_heartbeat.py.log
-rw-r--r-- 1 helixbot helixbot 0 Apr 27 22:47 start_helix.py.err
-rw-r--r-- 1 helixbot helixbot 194 Apr 27 22:47 start_helix.py.log
We could just change ownership of all log files every work item, but as a shorter term fix that's much safer I will explore making the packing test reporter only log to the console; this will still be logged, and will not create files across the mounted volume with incorrect user ownership.
Adding Error message to track impact
{ "ErrorMessage":"PermissionError: [Errno 13] Permission denied: '/root/helix/logs/run.py.log'" } Report
Summary
| Day Hit Count | Week Hit Count | Month Hit Count |
|---|---|---|
| 0 | 0 | 0 |