Additional RPMs for CBL-Mariner #7812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
I like that this solution is in the SDK so it automatically enables for all consumers.
It might be worth changing this to use the <MSBuild /> task and setting the PackageTargetOS property as a global property, but there's some extra concerns there that are a little hairy, so this implementation looks good for me. If we need to extend this in the future for another Linux distro, we can revisit.
This was referenced Sep 23, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/runtime#58141
Adds a copy of RPMs with CBL-Mariner version suffix, in the name. Skips projects that generate distro-specific RPMs (i.e. deps packages).