AddContainer does not have support for docker network

[thijscornelis]

Hi,

Is there some roadmap for adding more docker container capabilities? Right now, I see that there is support for Volumes and Replicas using the ResourceAnnotations.

builder.AddContainer(..)
    .WithAnnotation(new VolumeMountAnnotation(..))
    .WithAnnotation(new ReplicaAnnotation(..))

I was looking to create a set of containers that use a docker network. If it's something that is not meant to be done using ResourceAnnotations, could you guide me on how we should do it? I see no option to add arguments to the 'docker run' command?

Greetings!

P.S. I'm loving this project already :)

[karolz-ms]

What is the benefit of using Docker network for your app?

[davidfowl]

We shouldn't add support for docker networks but we should make a default network so that containers can reference each other by host name.

[thijscornelis]

What is the benefit of using Docker network for your app?

I was following a tutorial to get an Elastic container up & running. Didn't think twice if I really needed a separate docker network, as I'm quite new to containers.

[davidfowl]

That makes sense @thijscornelis. Can you share the tutorial?

[thijscornelis]

That makes sense @thijscornelis. Can you share the tutorial?

Sure, here you go: https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html

[Blind-Striker]

Another potential approach could be to leverage Dotnet Test containers and integrate it to Aspire. Testcontainers is a widely-used and well-established library within the community, offering robust and tested functionalities.

If this aligns with the project goals, I'm ready to open an issue to explore integrating Testcontainers. Thoughts?

Dotnet Testcontainers GitHub

[karolz-ms]

I agree with @davidfowl, we should be using a dedicated Docker network for running an Aspire app (and also use the Aspire component names for container names, instead of Docker auto-generated names).

@Blind-Striker thank you for pointing out the Testcontainers project, looks interesting, I will take a closer look.

[luizcarlosfaria]

We shouldn't add support for docker networks but we should make a default network so that containers can reference each other by host name.

Default networks in docker work's some different.

We can see on Docker Docs "Containers that attach to a custom network use Docker's embedded DNS server. The embedded DNS server forwards external DNS lookups to the DNS servers configured on the host." at https://docs.docker.com/network/#dns-services

Service discovery is part of custom docker networks, and when we connect some containers at this network, we're expecting that some containers talk to each other.

Kafka and zookeper, etcd and other service tools, elk stack or anything else, like a kong, nginx envoy etc need a custom docker network to use a docker service discovery.

[3GDXC]

IMHO Network configuration would be good as it would allow true infrastructure as code and follow what best practices with regards layer separation and firewall/port configuration testing in the developer environments.