Skip to content

Conversation

radical
Copy link
Member

@radical radical commented Oct 8, 2024

And get the msbuild debug files from crashes to aid debugging.

Issue: #6163

Microsoft Reviewers: Open in CodeFlow

@radical radical added area-engineering-systems infrastructure helix infra engineering repo stuff testing ☑️ labels Oct 8, 2024
@joperezr
Copy link
Member

joperezr commented Oct 8, 2024

Do we understand why the crash is happening though? How confident are we that when in a failure state, retrying will make this pass?

@radical
Copy link
Member Author

radical commented Oct 8, 2024

It doesn't crash like this on every build, but it does crash sometimes. So, this is just to ease the pain of having to do retries or having red builds on internal pipeline. Meanwhile, we are tracking the occurrence of these with #6163 .

@radical
Copy link
Member Author

radical commented Oct 11, 2024

@joperezr I think this would be useful to take.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @radical. If there is a way of not only retrying, but also keeping trace of when that needed to happen it would be great, as that way we won't get false-negatives indicating that this is no longer a problem, but that shouldn't block this.

@radical
Copy link
Member Author

radical commented Oct 11, 2024

LGTM, thanks @radical. If there is a way of not only retrying, but also keeping trace of when that needed to happen it would be great, as that way we won't get false-negatives indicating that this is no longer a problem, but that shouldn't block this.

I'm setting MSBUILDDEBUGPATH here, so we should get some debug logs from msbuild which we can use to further debug this.

@radical
Copy link
Member Author

radical commented Oct 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Oct 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit cbc8773 into dotnet:main Oct 21, 2024
9 checks passed
@radical radical deleted the retry-msbuild-failure branch October 21, 2024 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants