-
Notifications
You must be signed in to change notification settings - Fork 690
Retry tests if msbuild crashes #6181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we understand why the crash is happening though? How confident are we that when in a failure state, retrying will make this pass? |
It doesn't crash like this on every build, but it does crash sometimes. So, this is just to ease the pain of having to do retries or having red builds on internal pipeline. Meanwhile, we are tracking the occurrence of these with #6163 . |
@joperezr I think this would be useful to take. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @radical. If there is a way of not only retrying, but also keeping trace of when that needed to happen it would be great, as that way we won't get false-negatives indicating that this is no longer a problem, but that shouldn't block this.
I'm setting |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
And get the msbuild debug files from crashes to aid debugging.
Issue: #6163
Microsoft Reviewers: Open in CodeFlow