Skip to content

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Oct 15, 2024

Description

Saw that it was missing on SqlServer during Damian's demo.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

Saw that it was missing on SqlServer during Damian's demo.
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros sebastienros requested a review from eerhardt October 22, 2024 18:48
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt enabled auto-merge (squash) October 22, 2024 19:02
@eerhardt eerhardt merged commit 69cabab into main Oct 22, 2024
9 checks passed
@eerhardt eerhardt deleted the sebros/summaries branch October 22, 2024 20:15
@sebastienros
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11468909812

@sebastienros
Copy link
Member Author

@eerhardt As I was writing what validation I had just done to ensure it's working, I realized that moving it to <remarks> is actually breaking it. Because it will now "inherit" the remarks tags. So the /// <summary>latest</summary> on the tags now need to be in /// <remarks> too.

@eerhardt
Copy link
Member

So the /// <summary>latest</summary> on the tags now need to be in /// <remarks> too.

You mean "instead of" right?

@sebastienros
Copy link
Member Author

"too" because I changed summary to remarks, so the Tags also need the change. But yes.
I applied the change on the backport PR, assuming we can then merge release/9.0 back to main. Not sure we need to update it in main in that case.

@davidfowl
Copy link
Member

backport?

@eerhardt
Copy link
Member

backport?

#6433

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants